jenkins-bot has submitted this change and it was merged.
Change subject: Fix behavior of long-press in Nearby.
......................................................................
Fix behavior of long-press in Nearby.
Before this patch, long-pressing an item in Nearby took the user to the
Google Maps app, *and* simultaneously navigated to the page that was
pressed (which could potentially cause a crash, as well).
This makes it so that long-pressing an item *only* takes the user to the
Maps app, and doesn't navigate to the selected page.
Change-Id: I96373bd3b4de4219af244f81bc522b94e77070a7
---
M wikipedia/src/main/java/org/wikipedia/nearby/NearbyFragment.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikipedia/src/main/java/org/wikipedia/nearby/NearbyFragment.java
b/wikipedia/src/main/java/org/wikipedia/nearby/NearbyFragment.java
index ba81a9c..0e89483 100644
--- a/wikipedia/src/main/java/org/wikipedia/nearby/NearbyFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/nearby/NearbyFragment.java
@@ -178,7 +178,7 @@
// I think this case is rare enough for us to just ignore
// This would mean long pressing won't do anything, which
is fine, I think
}
- return false;
+ return true;
}
});
--
To view, visit https://gerrit.wikimedia.org/r/177255
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96373bd3b4de4219af244f81bc522b94e77070a7
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
