jenkins-bot has submitted this change and it was merged. Change subject: PostgreSQL: Port update-keys.sql to PostgreSQL ......................................................................
PostgreSQL: Port update-keys.sql to PostgreSQL This fixes the same bug in PostgreSQL that was reported against Oracle as bug 71040, using the same method of copying the update-keys.sql script into maintenance/postgres. Since all three copies of this file do the same thing, perhaps we should find lowest-common-denominator syntax that works in all databases to avoid redundant copies that can get out of sync with each other. (The Oracle and PostgreSQL versions are already identical to each other). The comments in the file are confusing and ungrammatical, but they are a copy of the same language from the other copies. Since I don't know what it is trying to say, I can't fix it. I have verified that this patch fixes the problem where mediawiki could not be installed with PostgreSQL using either the CLI or the web installer, due to SQL syntax errors. I haven't tested the the update-keys actually accomplishes whatever it was introduced to accomplish, though. Bug: 72834 Change-Id: I2a0cfa3dd0751b9fb65450b1537b6e77be60009a (cherry picked from commit 44b4b45bfa49f88f5ec92c4a445cdfe405841969) --- M RELEASE-NOTES-1.24 A maintenance/postgres/update-keys.sql 2 files changed, 38 insertions(+), 0 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24 index c5823fc..cef49cd 100644 --- a/RELEASE-NOTES-1.24 +++ b/RELEASE-NOTES-1.24 @@ -1,6 +1,15 @@ Security reminder: If you have PHP's register_globals option set, you must turn it off. MediaWiki will no longer work with it enabled. + +== MediaWiki 1.24.1 == + +This is a (XXX security and ??) maintenance release of the MediaWiki 1.24 branch. + +== Changes since 1.24.0 == + +* (bug 72834) Make 1.24 branch directly installable under PostgreSQL. + == MediaWiki 1.24 == MediaWiki 1.24.0 is the stable branch and is recommended for use in production. diff --git a/maintenance/postgres/update-keys.sql b/maintenance/postgres/update-keys.sql new file mode 100644 index 0000000..7761d0c --- /dev/null +++ b/maintenance/postgres/update-keys.sql @@ -0,0 +1,29 @@ +-- SQL to insert update keys into the initial tables after a +-- fresh installation of MediaWiki's database. +-- This is read and executed by the install script; you should +-- not have to run it by itself unless doing a manual install. +-- Insert keys here if either the unnecessary would cause heavy +-- processing or could potentially cause trouble by lowering field +-- sizes, adding constraints, etc. +-- When adjusting field sizes, it is recommended removing old +-- patches but to play safe, update keys should also inserted here. + +-- The /*_*/ comments in this and other files are +-- replaced with the defined table prefix by the installer +-- and updater scripts. If you are installing or running +-- updates manually, you will need to manually insert the +-- table prefix if any when running these scripts. +-- + +INSERT INTO /*_*/updatelog (ul_key, ul_value) + VALUES( 'filearchive-fa_major_mime-patch-fa_major_mime-chemical.sql', null ); +INSERT INTO /*_*/updatelog (ul_key, ul_value) + VALUES( 'image-img_major_mime-patch-img_major_mime-chemical.sql', null ); +INSERT INTO /*_*/updatelog (ul_key, ul_value) + VALUES( 'oldimage-oi_major_mime-patch-oi_major_mime-chemical.sql', null ); +INSERT INTO /*_*/updatelog (ul_key, ul_value) + VALUES( 'user_groups-ug_group-patch-ug_group-length-increase-255.sql', null ); +INSERT INTO /*_*/updatelog (ul_key, ul_value) + VALUES( 'user_former_groups-ufg_group-patch-ufg_group-length-increase-255.sql', null ); +INSERT INTO /*_*/updatelog (ul_key, ul_value) + VALUES( 'user_properties-up_property-patch-up_property.sql', null ); -- To view, visit https://gerrit.wikimedia.org/r/176291 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a0cfa3dd0751b9fb65450b1537b6e77be60009a Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: REL1_24 Gerrit-Owner: Legoktm <[email protected]> Gerrit-Reviewer: Jjanes <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: Parent5446 <[email protected]> Gerrit-Reviewer: Springle <[email protected]> Gerrit-Reviewer: Tim Landscheidt <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
