jenkins-bot has submitted this change and it was merged.
Change subject: Remove ve.instances
......................................................................
Remove ve.instances
A better API is provided by ve.init.target.getSurface(). Gadget
documentation has been updated to reflect this.
Change-Id: I823b492d1e3bc9496a359cb259b73240c3bf6ed0
---
M src/ui/ve.ui.Surface.js
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/ve.ui.Surface.js b/src/ui/ve.ui.Surface.js
index d648ffd..a001a0d 100644
--- a/src/ui/ve.ui.Surface.js
+++ b/src/ui/ve.ui.Surface.js
@@ -66,9 +66,6 @@
.append( this.view.$element );
this.localOverlay.$element.append( this.$blockers, this.$controls,
this.$menus );
this.globalOverlay.$element.append( this.dialogs.$element );
-
- // Make instance globally accessible for debugging
- ve.instances.push( this );
};
/* Inheritance */
@@ -94,9 +91,6 @@
* @fires destroy
*/
ve.ui.Surface.prototype.destroy = function () {
- // Remove instance from global array
- ve.instances.splice( ve.instances.indexOf( this ), 1 );
-
// Stop periodic history tracking in model
this.model.stopHistoryTracking();
--
To view, visit https://gerrit.wikimedia.org/r/176351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I823b492d1e3bc9496a359cb259b73240c3bf6ed0
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
