Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177430
Change subject: QA: update watchlist test for RSpec3 syntax
......................................................................
QA: update watchlist test for RSpec3 syntax
Change-Id: I2ac80afded4974173f17cbd57d5ec5eea566fe66
---
M tests/browser/features/special_watchlist.feature
M tests/browser/features/step_definitions/special_watchlist_steps.rb
2 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/30/177430/1
diff --git a/tests/browser/features/special_watchlist.feature
b/tests/browser/features/special_watchlist.feature
index 54ebde3..2723bc5 100644
--- a/tests/browser/features/special_watchlist.feature
+++ b/tests/browser/features/special_watchlist.feature
@@ -8,11 +8,11 @@
Scenario: Switching to Feed view
When I switch to the modified view of the watchlist
And I click the Pages tab
- Then I see a list of diff summary links
- And the modified button is selected
+ Then I should see a list of diff summary links
+ And the modified button should be selected
Scenario: Switching to List view
When I switch to the modified view of the watchlist
And I switch to the list view of the watchlist
- Then I see a list of pages I am watching
- And the a to z button is selected
+ Then I should see a list of pages I am watching
+ And the a to z button should be selected
diff --git a/tests/browser/features/step_definitions/special_watchlist_steps.rb
b/tests/browser/features/step_definitions/special_watchlist_steps.rb
index 4e4d4c7..8cca8f9 100644
--- a/tests/browser/features/step_definitions/special_watchlist_steps.rb
+++ b/tests/browser/features/step_definitions/special_watchlist_steps.rb
@@ -2,26 +2,26 @@
on(WatchlistPage).pages_tab_link_element.when_present.click
end
-When(/^I switch to the modified view of the watchlist$/) do
- on(WatchlistPage).feed_link_element.click
-end
-
When(/^I switch to the list view of the watchlist$/) do
on(WatchlistPage).list_link_element.click
end
-Then(/^I see a list of diff summary links$/) do
+When(/^I switch to the modified view of the watchlist$/) do
+ on(WatchlistPage).feed_link_element.click
+end
+
+Then(/^I should see a list of diff summary links$/) do
on(WatchlistPage).page_list_diffs_element.when_present.should be_visible
end
-Then(/^I see a list of pages I am watching$/) do
+Then(/^I should see a list of pages I am watching$/) do
on(WatchlistPage).page_list_a_to_z_element.when_present.should be_visible
end
-Then(/^the modified button is selected$/) do
- on(WatchlistPage).feed_link_element.parent.element().class_name.should match
/active/
+Then(/^the a to z button should be selected$/) do
+ on(WatchlistPage).list_link_element.parent.element().class_name.should match
/active/
end
-Then(/^the a to z button is selected$/) do
- on(WatchlistPage).list_link_element.parent.element().class_name.should match
/active/
+Then(/^the modified button should be selected$/) do
+ on(WatchlistPage).feed_link_element.parent.element().class_name.should match
/active/
end
--
To view, visit https://gerrit.wikimedia.org/r/177430
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ac80afded4974173f17cbd57d5ec5eea566fe66
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
