Pwirth has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177531
Change subject: UniversalExport: Fixed permission error for special pages
......................................................................
UniversalExport: Fixed permission error for special pages
* Used isAllowed instead of userCan if requested title is a special page
* Added descriptiom
Change-Id: Idef3128d6dc9e297bedaa8324adfef6b076a7ccc
---
M UniversalExport/includes/specials/SpecialUniversalExport.class.php
1 file changed, 6 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions
refs/changes/31/177531/1
diff --git a/UniversalExport/includes/specials/SpecialUniversalExport.class.php
b/UniversalExport/includes/specials/SpecialUniversalExport.class.php
index ae9e094..0c445c7 100644
--- a/UniversalExport/includes/specials/SpecialUniversalExport.class.php
+++ b/UniversalExport/includes/specials/SpecialUniversalExport.class.php
@@ -132,7 +132,12 @@
BsUniversalExportHelper::getParamsFromQueryString(
$this->aParams );
- if ( $this->oRequestedTitle->userCan(
'universalexport-export' ) === false ) {
+ //Title::userCan always returns false on special pages
(exept for createaccount action)
+ if( $this->oRequestedTitle->getNamespace() ===
NS_SPECIAL ) {
+ if(
$this->getUser()->isAllowed('universalexport-export') !== true ){
+ throw new Exception(
'bs-universalexport-error-permission');
+ }
+ } elseif( $this->oRequestedTitle->userCan(
'universalexport-export' ) === false ) {
throw new Exception(
'bs-universalexport-error-permission');
}
--
To view, visit https://gerrit.wikimedia.org/r/177531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idef3128d6dc9e297bedaa8324adfef6b076a7ccc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_22
Gerrit-Owner: Pwirth <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
