jenkins-bot has submitted this change and it was merged.
Change subject: Revert "Don't insert banner for bots"
......................................................................
Revert "Don't insert banner for bots"
This reverts commit 62742836702db175bfa7cfa31d229451ebd1c13b.
Change-Id: I999d8dc0b9151b7f6891c9245920ec29c39b96aa
---
M modules/ext.centralNotice.bannerController/bannerController.js
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
AndyRussG: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.centralNotice.bannerController/bannerController.js
b/modules/ext.centralNotice.bannerController/bannerController.js
index fb2f671..26891cd 100644
--- a/modules/ext.centralNotice.bannerController/bannerController.js
+++ b/modules/ext.centralNotice.bannerController/bannerController.js
@@ -356,10 +356,6 @@
var url, targets, durations, cookieName, cookieVal, deleteOld,
now,
parsedCookie, bucket;
- if ( navigator.userAgent.match (
/bot|googlebot|crawler|spider|robot|crawling/i ) ) {
- return;
- }
-
var impressionData = {
country: mw.centralNotice.data.country,
uselang: mw.config.get( 'wgUserLanguage' ),
--
To view, visit https://gerrit.wikimedia.org/r/177669
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I999d8dc0b9151b7f6891c9245920ec29c39b96aa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
