Trevor Parscal has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177681
Change subject: Fix lies in documentation
......................................................................
Fix lies in documentation
Not only was "outlineItem" not an argument, but rather a configuration option,
but it was completely ignore in BookletLayout and overwritten by a fresh new
OutlineItemWidget when the page was added.
Change-Id: I8cf26f9ed5ee27d80f18d056563dcb9b0154c872
---
M src/layouts/PageLayout.js
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/81/177681/1
diff --git a/src/layouts/PageLayout.js b/src/layouts/PageLayout.js
index dba6c47..67cd11b 100644
--- a/src/layouts/PageLayout.js
+++ b/src/layouts/PageLayout.js
@@ -7,7 +7,6 @@
* @constructor
* @param {string} name Unique symbolic name of page
* @param {Object} [config] Configuration options
- * @param {string} [outlineItem] Outline item widget
*/
OO.ui.PageLayout = function OoUiPageLayout( name, config ) {
// Configuration initialization
@@ -18,7 +17,7 @@
// Properties
this.name = name;
- this.outlineItem = config.outlineItem || null;
+ this.outlineItem = null;
this.active = false;
// Initialization
--
To view, visit https://gerrit.wikimedia.org/r/177681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cf26f9ed5ee27d80f18d056563dcb9b0154c872
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
