jenkins-bot has submitted this change and it was merged.
Change subject: search-redirect: check for parameter existence consistently
......................................................................
search-redirect: check for parameter existence consistently
Change-Id: I24437591bb6df7d3cbfa9bdb4a48b1c2b863f2b1
---
M search-redirect.php
1 file changed, 4 insertions(+), 9 deletions(-)
Approvals:
Hoo man: Looks good to me, but someone else must approve
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/search-redirect.php b/search-redirect.php
index a856d2d..ea7169f 100644
--- a/search-redirect.php
+++ b/search-redirect.php
@@ -1,15 +1,10 @@
<?php
// get params
-$language = $_GET['language'];
-$search = $_GET['search'];
+$language = isset( $_GET['language'] ) ? $_GET['language'] : '';
+$search = isset( $_GET['search'] ) ? $_GET['search'] : '';
$fulltext = isset( $_GET['fulltext'] ) ? $_GET['fulltext'] : false;
-$go = $_GET['go'];
-
-if ( isset( $_GET['family'] ) ) {
- $family = $_GET['family'];
-} else {
- $family = 'wikipedia';
-}
+$go = isset( $_GET['go'] ) ? $_GET['go'] : false;
+$family = isset( $_GET['family'] ) ? $_GET['family'] : 'wikipedia';
if ( ( isset( $_SERVER['HTTP_X_FORWARDED_PROTO'] ) &&
$_SERVER['HTTP_X_FORWARDED_PROTO'] === 'https' )
|| ( isset( $_SERVER['HTTPS'] ) && $_SERVER['HTTPS'] === 'on' )
--
To view, visit https://gerrit.wikimedia.org/r/177665
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24437591bb6df7d3cbfa9bdb4a48b1c2b863f2b1
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
