Pietrodn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177767
Change subject: Improving the patch.
......................................................................
Improving the patch.
Using data['snaks'].keys() for clarity.
Documentation of the patch.
Change-Id: I2c0aafc13795393b3111ab32c9a37445a36ee9f5
---
M pywikibot/page.py
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/67/177767/1
diff --git a/pywikibot/page.py b/pywikibot/page.py
index e60917b..3ec3f37 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -3624,10 +3624,14 @@
@return: dict
"""
source = OrderedDict()
+
+ # Before #84516 Wikibase did not implement snaks-order.
+ # https://gerrit.wikimedia.org/r/#/c/84516/
if 'snaks-order' in data:
- propList = data['snaks-order']
+ propList = data['snaks-order'].keys()
else:
- propList = data['snaks']
+ propList = data['snaks'].keys()
+
for prop in propList:
for claimsnak in data['snaks'][prop]:
claim = Claim.fromJSON(site, {'mainsnak': claimsnak,
--
To view, visit https://gerrit.wikimedia.org/r/177767
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c0aafc13795393b3111ab32c9a37445a36ee9f5
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Pietrodn <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
