Mhurd has submitted this change and it was merged.
Change subject: Add 'entitydescription' prop on MWKArticle
......................................................................
Add 'entitydescription' prop on MWKArticle
will need to be manually filled in on query since it's
not part of the mobileview API base dataset; once added
just save and it should work.
Change-Id: I3aef07031c3b07543383597e5f7113087e118326
---
M MediaWikiKit/MediaWikiKit/MWKArticle.h
M MediaWikiKit/MediaWikiKit/MWKArticle.m
2 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Mhurd: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/MediaWikiKit/MediaWikiKit/MWKArticle.h
b/MediaWikiKit/MediaWikiKit/MWKArticle.h
index ca70ea1..fba2795 100644
--- a/MediaWikiKit/MediaWikiKit/MWKArticle.h
+++ b/MediaWikiKit/MediaWikiKit/MWKArticle.h
@@ -30,6 +30,8 @@
@property (readonly) MWKProtectionStatus *protection; // required
@property (readonly) BOOL editable; // required
+@property (readonly) NSString *entitydescription; // optional;
pulled via wikidata
+
-(instancetype)initWithTitle:(MWKTitle *)title dict:(NSDictionary *)dict;
@end
diff --git a/MediaWikiKit/MediaWikiKit/MWKArticle.m
b/MediaWikiKit/MediaWikiKit/MWKArticle.m
index e010a47..72fdc2a 100644
--- a/MediaWikiKit/MediaWikiKit/MWKArticle.m
+++ b/MediaWikiKit/MediaWikiKit/MWKArticle.m
@@ -24,6 +24,9 @@
_displaytitle = [self optionalString: @"displaytitle"
dict:dict];
_protection = [self requiredProtectionStatus:@"protection"
dict:dict];
_editable = [[self requiredNumber: @"editable"
dict:dict] boolValue];
+
+ // This doesn't come from mobileview api, queried separately
+ _entitydescription = [self optionalString: @"entitydescription"
dict:dict];
}
return self;
}
@@ -47,6 +50,11 @@
dict[@"protection"] = [self.protection dataExport];
dict[@"editable"] = @(self.editable);
+ if (self.entitydescription) {
+ // This doesn't come from mobileview api, queried separately
+ dict[@"entitydescription"] = self.entitydescription;
+ }
+
return [NSDictionary dictionaryWithDictionary:dict];
}
--
To view, visit https://gerrit.wikimedia.org/r/177661
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3aef07031c3b07543383597e5f7113087e118326
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Mhurd <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
