Mhurd has submitted this change and it was merged.
Change subject: Fix regression in toggleImageSheet magic
......................................................................
Fix regression in toggleImageSheet magic
Change-Id: Iabdc26192edaa0c5683f37d17e55715c2c25fa3a
---
M wikipedia/View Controllers/WebView/WebViewController.m
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Mhurd: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikipedia/View Controllers/WebView/WebViewController.m
b/wikipedia/View Controllers/WebView/WebViewController.m
index f6201e6..4f91518 100644
--- a/wikipedia/View Controllers/WebView/WebViewController.m
+++ b/wikipedia/View Controllers/WebView/WebViewController.m
@@ -1334,9 +1334,9 @@
if(showImageSheet){
MWKArticleStore *articleStore = session.articleStore;
+ NSMutableArray *views = @[].mutableCopy;
for (MWKSection *section in articleStore.sections) {
NSArray *sectionImages = [articleStore
UIImagesForSectionId:section.sectionId];
- NSMutableArray *views = @[].mutableCopy;
int index = 0;
for (UIImage *image in sectionImages) {
NSString *title = (section.line) ? section.line :
articleStore.title.prefixedText;
@@ -1360,8 +1360,9 @@
[views addObject:spacerView];
index++;
}
- [NAV topActionSheetShowWithViews:views
orientation:TABULAR_SCROLLVIEW_LAYOUT_HORIZONTAL];
}
+ NSLog(@"%@", views);
+ [NAV topActionSheetShowWithViews:views
orientation:TABULAR_SCROLLVIEW_LAYOUT_HORIZONTAL];
}else{
[NAV topActionSheetHide];
}
--
To view, visit https://gerrit.wikimedia.org/r/177680
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabdc26192edaa0c5683f37d17e55715c2c25fa3a
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Mhurd <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
