Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177882
Change subject: phpcs: The abstract declaration must precede the visibility
......................................................................
phpcs: The abstract declaration must precede the visibility
Change-Id: I957eb6007f110252726e67c1fb7099b02fdca676
---
M includes/db/LBFactory.php
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/82/177882/1
diff --git a/includes/db/LBFactory.php b/includes/db/LBFactory.php
index e049a5d..c05188a 100644
--- a/includes/db/LBFactory.php
+++ b/includes/db/LBFactory.php
@@ -109,7 +109,7 @@
* Construct a factory based on a configuration array (typically from
$wgLBFactoryConf)
* @param array $conf
*/
- public abstract function __construct( array $conf );
+ abstract public function __construct( array $conf );
/**
* Create a new load balancer object. The resulting object will be
untracked,
@@ -118,7 +118,7 @@
* @param bool|string $wiki Wiki ID, or false for the current wiki
* @return LoadBalancer
*/
- public abstract function newMainLB( $wiki = false );
+ abstract public function newMainLB( $wiki = false );
/**
* Get a cached (tracked) load balancer object.
@@ -126,7 +126,7 @@
* @param bool|string $wiki Wiki ID, or false for the current wiki
* @return LoadBalancer
*/
- public abstract function getMainLB( $wiki = false );
+ abstract public function getMainLB( $wiki = false );
/**
* Create a new load balancer for external storage. The resulting
object will be
@@ -137,7 +137,7 @@
* @param bool|string $wiki Wiki ID, or false for the current wiki
* @return LoadBalancer
*/
- protected abstract function newExternalLB( $cluster, $wiki = false );
+ abstract protected function newExternalLB( $cluster, $wiki = false );
/**
* Get a cached (tracked) load balancer for external storage
@@ -146,7 +146,7 @@
* @param bool|string $wiki Wiki ID, or false for the current wiki
* @return LoadBalancer
*/
- public abstract function &getExternalLB( $cluster, $wiki = false );
+ abstract public function &getExternalLB( $cluster, $wiki = false );
/**
* Execute a function for each tracked load balancer
@@ -156,7 +156,7 @@
* @param callable $callback
* @param array $params
*/
- public abstract function forEachLB( $callback, array $params = array()
);
+ abstract public function forEachLB( $callback, array $params = array()
);
/**
* Prepare all tracked load balancers for shutdown
--
To view, visit https://gerrit.wikimedia.org/r/177882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I957eb6007f110252726e67c1fb7099b02fdca676
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
