Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177937
Change subject: Hide Details box when user taps the image
......................................................................
Hide Details box when user taps the image
On some devices this will give a little more space to see the image.
Initially state is always a visible details box.
Bug: T70504
Change-Id: Id93af2b3ad1bf3c2789522edb622d131c4c7a53a
---
M javascripts/modules/mediaViewer/ImageOverlay.js
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/37/177937/1
diff --git a/javascripts/modules/mediaViewer/ImageOverlay.js
b/javascripts/modules/mediaViewer/ImageOverlay.js
index 2bd8d7e..cc03633 100644
--- a/javascripts/modules/mediaViewer/ImageOverlay.js
+++ b/javascripts/modules/mediaViewer/ImageOverlay.js
@@ -76,6 +76,21 @@
} );
$( window ).on( 'resize', $.proxy( this,
'_positionImage' ) );
+
+ this.$( '.image-wrapper' ).on( 'click', function () {
+ var $details = self.$( '.details' );
+
+ if ( self.isDetailsHidden ) {
+ // show the details box
+ self.$( '.details' ).show();
+ self.isDetailsHidden = false;
+ } else {
+ // hide the details box
+ $details.hide();
+ self.isDetailsHidden = true;
+ }
+ self._positionImage();
+ } );
},
show: function () {
@@ -84,7 +99,8 @@
},
_positionImage: function () {
- var detailsHeight = this.$( '.details' ).outerHeight(),
+ // with a hidden details box we have a little bit more
space, we just need to use it
+ var detailsHeight = this.isDetailsHidden ? 0 : this.$(
'.details' ).outerHeight(),
windowWidth = $( window ).width(),
windowHeight = $( window ).height() -
detailsHeight,
windowRatio = windowWidth / windowHeight,
--
To view, visit https://gerrit.wikimedia.org/r/177937
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id93af2b3ad1bf3c2789522edb622d131c4c7a53a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
