Faidon Liambotis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/178160

Change subject: autoinstall: set get_domain=unassigned on jessie
......................................................................

autoinstall: set get_domain=unassigned on jessie

d-i's netcfg has a bug where the DHCP domain name option gets ignored
for preseeding purposes and manual input is required. I debugged this
extensively and filled it as https://bugs.debian.org/772523.

As we run the installer with priority=high (the default), meaning that
we get prompted for >= high questions, this breaks automated installs
in Debian. The bug exists in Ubuntu as well, but Ubuntu has a custom
patch on top of netcfg that downgrades that question to priority=medium.
The reason for that is unknown, as in a typical Ubuntu fashion, the
custom patch is undocumented in the Ubuntu source and was never
forwarded to Debian along with a reational. It's possible it's a wrong
fix for the bug above (as the domain is prefilled).

Besides pushing for a fix in time for jessie, we have the following
options for a workaround:
1) Set d-i to priority=critical. This may be a good idea anyway but as
this touches far more that netcfg, it's not a great workaround.
2) Remove "option domain-name" from our DHCP config; d-i would resort to
the hostname found in the FQDN and the bug would not manifest. This is
not a very elegant solution.
3) Bundle the isc-dhcp-client udeb into a gzipped cpio and append it to
jessie's initrd. I approached this solution but it got messy real quick
(multiple library udeb dependencies, glibc incompatibilities etc.)
4) Trick d-i by setting netcfg/get_domain to "unassigned" (or any other
value) in the kernel command-prompt, similar to how we set
netcfg/get_hostname to "unassigned" too. This affects only the bootstrap
phase of the installer anyway, as immediately after netcfg comes
preseeding and we preseed domain-name anyway, under our subnets/
configuration.

This implements solution (4). As the bug doesn't manifest in Ubuntu (as
explained above), this touches only the jessie config.

Change-Id: Ibd8cb5d4dab0b8480e09178d06d4fc4cccc68577
---
M 
modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-115200
M 
modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-57600
M modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-9600
M 
modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS1-115200
M 
modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS1-57600
5 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/60/178160/1

diff --git 
a/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-115200
 
b/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-115200
index b8f9100..5ff9303 100644
--- 
a/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-115200
+++ 
b/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-115200
@@ -9,4 +9,4 @@
 
 LABEL server
        kernel debian-installer/amd64/linux
-       append initrd=debian-installer/amd64/initrd.gz vga=normal 
auto-install/enable=true 
preseed/url=http://apt.wikimedia.org/autoinstall/preseed.cfg DEBCONF_DEBUG=5 
netcfg/choose_interface=auto netcfg/get_hostname=unassigned 
netcfg/dhcp_timeout=60 --- console=ttyS0,115200n8
+       append initrd=debian-installer/amd64/initrd.gz vga=normal 
auto-install/enable=true 
preseed/url=http://apt.wikimedia.org/autoinstall/preseed.cfg DEBCONF_DEBUG=5 
netcfg/choose_interface=auto netcfg/get_hostname=unassigned 
netcfg/get_domain=unassigned netcfg/dhcp_timeout=60 --- console=ttyS0,115200n8
diff --git 
a/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-57600
 
b/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-57600
index 11cf075..e44460f 100644
--- 
a/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-57600
+++ 
b/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-57600
@@ -9,4 +9,4 @@
 
 LABEL server
        kernel debian-installer/amd64/linux
-       append initrd=debian-installer/amd64/initrd.gz vga=normal 
auto-install/enable=true 
preseed/url=http://apt.wikimedia.org/autoinstall/preseed.cfg DEBCONF_DEBUG=5 
netcfg/choose_interface=auto netcfg/get_hostname=unassigned 
netcfg/dhcp_timeout=60 --- console=ttyS0,57600n8
+       append initrd=debian-installer/amd64/initrd.gz vga=normal 
auto-install/enable=true 
preseed/url=http://apt.wikimedia.org/autoinstall/preseed.cfg DEBCONF_DEBUG=5 
netcfg/choose_interface=auto netcfg/get_hostname=unassigned 
netcfg/get_domain=unassigned netcfg/dhcp_timeout=60 --- console=ttyS0,57600n8
diff --git 
a/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-9600
 
b/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-9600
index 3b6bc36..a8ea103 100644
--- 
a/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-9600
+++ 
b/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS0-9600
@@ -9,4 +9,4 @@
 
 LABEL server
        kernel debian-installer/amd64/linux
-       append initrd=debian-installer/amd64/initrd.gz vga=normal 
auto-install/enable=true 
preseed/url=http://apt.wikimedia.org/autoinstall/preseed.cfg DEBCONF_DEBUG=5 
netcfg/choose_interface=auto netcfg/get_hostname=unassigned 
netcfg/dhcp_timeout=60 --- console=ttyS0,9600n8
+       append initrd=debian-installer/amd64/initrd.gz vga=normal 
auto-install/enable=true 
preseed/url=http://apt.wikimedia.org/autoinstall/preseed.cfg DEBCONF_DEBUG=5 
netcfg/choose_interface=auto netcfg/get_hostname=unassigned 
netcfg/get_domain=unassigned netcfg/dhcp_timeout=60 --- console=ttyS0,9600n8
diff --git 
a/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS1-115200
 
b/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS1-115200
index 1075a77..d147921 100644
--- 
a/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS1-115200
+++ 
b/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS1-115200
@@ -9,4 +9,4 @@
 
 LABEL server
        kernel debian-installer/amd64/linux
-       append initrd=debian-installer/amd64/initrd.gz vga=normal 
auto-install/enable=true 
preseed/url=http://apt.wikimedia.org/autoinstall/preseed.cfg DEBCONF_DEBUG=5 
netcfg/choose_interface=auto netcfg/get_hostname=unassigned 
netcfg/dhcp_timeout=60 --- console=ttyS1,115200n8
+       append initrd=debian-installer/amd64/initrd.gz vga=normal 
auto-install/enable=true 
preseed/url=http://apt.wikimedia.org/autoinstall/preseed.cfg DEBCONF_DEBUG=5 
netcfg/choose_interface=auto netcfg/get_hostname=unassigned 
netcfg/get_domain=unassigned netcfg/dhcp_timeout=60 --- console=ttyS1,115200n8
diff --git 
a/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS1-57600
 
b/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS1-57600
index 1a34cb5..3c612f9 100644
--- 
a/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS1-57600
+++ 
b/modules/install-server/files/tftpboot/jessie-installer/pxelinux.cfg/ttyS1-57600
@@ -9,4 +9,4 @@
 
 LABEL server
        kernel debian-installer/amd64/linux
-       append initrd=debian-installer/amd64/initrd.gz vga=normal 
auto-install/enable=true 
preseed/url=http://apt.wikimedia.org/autoinstall/preseed.cfg DEBCONF_DEBUG=5 
netcfg/choose_interface=auto netcfg/get_hostname=unassigned 
netcfg/dhcp_timeout=60 --- console=ttyS1,57600n8
+       append initrd=debian-installer/amd64/initrd.gz vga=normal 
auto-install/enable=true 
preseed/url=http://apt.wikimedia.org/autoinstall/preseed.cfg DEBCONF_DEBUG=5 
netcfg/choose_interface=auto netcfg/get_hostname=unassigned 
netcfg/get_domain=unassigned netcfg/dhcp_timeout=60 --- console=ttyS1,57600n8

-- 
To view, visit https://gerrit.wikimedia.org/r/178160
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd8cb5d4dab0b8480e09178d06d4fc4cccc68577
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <fai...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to