jenkins-bot has submitted this change and it was merged. Change subject: Fix bad spacing in topic title on monobook ......................................................................
Fix bad spacing in topic title on monobook Best practices[1] encourage using unitless line height, specifying line-height with em's inherits differently causing rendering errors such as the topic title in monobook. I reviewed all the places these are used in with both monobook and vector. There are some tiny changes in line height removing the em's but it generally looks the same. Note that some of these locations aren't actually used. navagiation.less is unreferenced from the templates. forms.less has a few line-height definitions, but only the first for .mw-ui-input-large is used(for the nojs new topic link). The others are referenced from form_element.handlebars but that template is never called either. [1] https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#Prefer_unitless_numbers_for_line-height_values Bug: T76602 Change-Id: I00007404dea26ec1cf2a42c45dec93ce126cb4a9 --- M modules/styles/board/replycount.less M modules/styles/board/terms-of-use.less M modules/styles/board/timestamps.less M modules/styles/board/topic/navigation.less M modules/styles/board/topic/post.less M modules/styles/mediawiki.ui/forms.less M modules/styles/mediawiki.ui/modal.less 7 files changed, 9 insertions(+), 11 deletions(-) Approvals: Matthias Mullie: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/styles/board/replycount.less b/modules/styles/board/replycount.less index fe18ca6..8b53853 100644 --- a/modules/styles/board/replycount.less +++ b/modules/styles/board/replycount.less @@ -23,7 +23,7 @@ width: 100%; color: @colorTextLight; font-size: .5em; - line-height: 2.25em; + line-height: 2.25; font-weight: bold; text-align: center; } diff --git a/modules/styles/board/terms-of-use.less b/modules/styles/board/terms-of-use.less index 3d29220..e7ecd5f 100644 --- a/modules/styles/board/terms-of-use.less +++ b/modules/styles/board/terms-of-use.less @@ -10,6 +10,6 @@ height: 3.6em; vertical-align: middle; color: @colorTextLight; - font-size: .75em; - line-height: 1.5em; + font-size: .75em; + line-height: 1.4; } diff --git a/modules/styles/board/timestamps.less b/modules/styles/board/timestamps.less index 67e19ba..9356cba 100644 --- a/modules/styles/board/timestamps.less +++ b/modules/styles/board/timestamps.less @@ -18,12 +18,10 @@ .flow-timestamp-user-formatted { display: block; position: relative; - line-height: 1em; } .flow-timestamp-ago { margin-top: -1em; - line-height: 1em; } .client-js { diff --git a/modules/styles/board/topic/navigation.less b/modules/styles/board/topic/navigation.less index f864467..25d4414 100644 --- a/modules/styles/board/topic/navigation.less +++ b/modules/styles/board/topic/navigation.less @@ -14,7 +14,7 @@ float: right; border-radius: 3px; font-size: .875em; - line-height: 1.1em; + line-height: 1.1; h5 { color: @colorText; diff --git a/modules/styles/board/topic/post.less b/modules/styles/board/topic/post.less index 1a478b4..90b0332 100644 --- a/modules/styles/board/topic/post.less +++ b/modules/styles/board/topic/post.less @@ -105,7 +105,7 @@ // Author link in post .flow-author { font-size: .875em; - line-height: 1.2em; + line-height: 1.2; display: inline-block; color: @colorText; word-wrap: break-word; diff --git a/modules/styles/mediawiki.ui/forms.less b/modules/styles/mediawiki.ui/forms.less index 181696f..cb371b8 100644 --- a/modules/styles/mediawiki.ui/forms.less +++ b/modules/styles/mediawiki.ui/forms.less @@ -16,7 +16,7 @@ margin: 0; font-size: 1.75em; font-style: italic; - line-height: 1.25em; + line-height: 1.25; color: @colorTextLight; } } @@ -89,7 +89,7 @@ width: 2em; color: @colorGrayLight; font-size: 1em; - line-height: 1em; + line-height: 1; text-align: center; pointer-events: none; //.glyphicon diff --git a/modules/styles/mediawiki.ui/modal.less b/modules/styles/mediawiki.ui/modal.less index c27e0e0..463010c 100644 --- a/modules/styles/mediawiki.ui/modal.less +++ b/modules/styles/mediawiki.ui/modal.less @@ -55,7 +55,7 @@ padding: 0 .3em; font-weight: bold; color: @colorText; - line-height: 2.2em; + line-height: 2.2; border-bottom: 1px solid @colorGrayLight; } @@ -81,4 +81,4 @@ .flow-ui-modal-content { overflow: hidden; margin: 1.3em; -} \ No newline at end of file +} -- To view, visit https://gerrit.wikimedia.org/r/177165 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00007404dea26ec1cf2a42c45dec93ce126cb4a9 Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: EBernhardson <[email protected]> Gerrit-Reviewer: Matthias Mullie <[email protected]> Gerrit-Reviewer: SG <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
