jenkins-bot has submitted this change and it was merged.
Change subject: Fix failing test in master
......................................................................
Fix failing test in master
String.replace interprets a plain string as an exact text to match
against, but String.match interprets it as a regexp. Javascript is
fun.
Change-Id: I93ac31079f1f87dffdf0d5e02df2fa38ae79a6cc
---
M tests/qunit/mmv/mmv.EmbedFileFormatter.test.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/qunit/mmv/mmv.EmbedFileFormatter.test.js
b/tests/qunit/mmv/mmv.EmbedFileFormatter.test.js
index b7875a0..54c7c69 100644
--- a/tests/qunit/mmv/mmv.EmbedFileFormatter.test.js
+++ b/tests/qunit/mmv/mmv.EmbedFileFormatter.test.js
@@ -49,7 +49,7 @@
siteLink = formatter.getSiteLink( info );
assert.ok( siteLink.match( 'Wikipedia' ), 'Site name is present
in site link' );
- assert.ok( siteLink.match( siteUrl ), 'Site URL is present in
site link' );
+ assert.ok( siteLink.indexOf( siteUrl ) !== -1, 'Site URL is
present in site link' );
} );
--
To view, visit https://gerrit.wikimedia.org/r/178272
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93ac31079f1f87dffdf0d5e02df2fa38ae79a6cc
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
