Robmoen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/178386

Change subject: Beta border sanity
......................................................................

Beta border sanity

Force consistent border width
Blend with background with either white
or transparent borders.

Change-Id: I15dd433d1cd4dd98a63b0bd20bd77bb2359714eb
---
M includes/Resources.php
A less/content/borders.less
2 files changed, 63 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/86/178386/1

diff --git a/includes/Resources.php b/includes/Resources.php
index e370c25..78da405 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -710,6 +710,12 @@
                ),
        ),
 
+       'mobile.tables.beta' => $wgMFResourceFileModuleBoilerplate + array(
+               'styles' => array(
+                       'less/content/borders.less',
+               ),
+       ),
+
        'mobile.references' => $wgMFResourceFileModuleBoilerplate + array(
                'dependencies' => array(
                        'mobile.drawers',
@@ -1291,6 +1297,7 @@
                        // load code under certain conditions.
                        'mobile.preferredLanguages',
                        'mobile.references.beta',
+                       'mobile.tables.beta'
                ),
        ),
        'mobile.alpha' => $wgMFResourceFileModuleBoilerplate + array(
diff --git a/less/content/borders.less b/less/content/borders.less
new file mode 100644
index 0000000..7fb15c4
--- /dev/null
+++ b/less/content/borders.less
@@ -0,0 +1,56 @@
+
+
+
+
+table,tr,tbody,td,th,div,span {
+    /*  -   -   -   -   -   -   -   -   -   -   -   -   -   -   -   -   -   -  
 -   -
+    Get rid of hideous gray and black borders everywhere while still retaining 
visual 
+    separation between elements by forcing consistent, white borders with 
specific 
+    elements. Note: this has no effect if border-style was unset. Used 2px to 
maintain 
+    obvious visual separation (1px is too fine). Used white to convert all 
hideous gray 
+    borders into far less hideous white spacing. White has essential benefit 
of making 
+    nested borders blend with each other and the background.
+    */
+    // FIXME: remove important if promoted to stable
+    border-width: 2px !important; 
+    // Fallback
+    border-color: #fff !important;
+    // Transparent border
+    border-color: rgba(255, 255, 255, 0) !important;
+}
+
+
+
+td {
+    /*
+    Only if the background color isn't set, set a slight gray. This is done to 
work
+    in conjunction with white border styling. (If we don't do a slight gray 
for 
+    unset td background colors, the white border styling doesn't stand out 
against 
+    the body tag's white background.)
+    */
+    background-color: #f7f7f7; /* Don't use important keyword for this one! */
+}
+
+
+
+hr {
+    // FIXME: remove important if promoted to stable
+    border-width: 0px !important;
+    height: 2px !important;
+    // Fallback
+    background-color: #fff !important;
+    // Transparent background
+    background-color: rgba(255, 255, 255, 0) !important;
+}
+
+
+
+img {
+    // FIXME: remove important if promoted to stable
+    border-width: 1px !important;
+    // Fallback
+    border-color: #fff !important;
+    // Transparent border
+    border-color: rgba(255, 255, 255, 0) !important;
+}
+

-- 
To view, visit https://gerrit.wikimedia.org/r/178386
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I15dd433d1cd4dd98a63b0bd20bd77bb2359714eb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to