Gergő Tisza has uploaded a new change for review.
https://gerrit.wikimedia.org/r/178406
Change subject: Fix for broken thumbnails when the file width is in
$wgThumbnailBucket
......................................................................
Fix for broken thumbnails when the file width is in $wgThumbnailBucket
When the source file width equals a bucket width,
File::getThumbnailBucket() suggests the use of a thumbnail of that
size. A thumbnail with the same width as the original is usually
an error; somehow this error results in an empty file being created,
and used as the intermediary thumbnail for everything in the top
bucket.
Bug: T77950
Change-Id: I8c2fdd9b51d227f34cac874ed2b16c87adc9315d
---
M includes/filerepo/file/File.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/06/178406/1
diff --git a/includes/filerepo/file/File.php b/includes/filerepo/file/File.php
index c82be50..ae6b659 100644
--- a/includes/filerepo/file/File.php
+++ b/includes/filerepo/file/File.php
@@ -492,7 +492,7 @@
sort( $sortedBuckets );
foreach ( $sortedBuckets as $bucket ) {
- if ( $bucket > $imageWidth ) {
+ if ( $bucket >= $imageWidth ) {
return false;
}
--
To view, visit https://gerrit.wikimedia.org/r/178406
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c2fdd9b51d227f34cac874ed2b16c87adc9315d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
