jenkins-bot has submitted this change and it was merged.

Change subject: Fix for bug T76982
......................................................................


Fix for bug T76982

Switch uses of 'ev.target' to 'this' to fix cases
where click events come from children of anchor tags

See https://phabricator.wikimedia.org/T76982

Change-Id: I51f186c5d92baa4be46f495d9a7ffd761048e344
---
M modules/interstitial.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yurik: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/interstitial.js b/modules/interstitial.js
index 828a9c8..7272a36 100644
--- a/modules/interstitial.js
+++ b/modules/interstitial.js
@@ -77,7 +77,7 @@
                                        // a hardcoded list of our sites - 
avoids api call if not listed
                                        'm.wikipedia', 'zero.wikipedia'
                                ],
-                               $target = $( ev.target ), // onclick <a> element
+                               $target =$( this ), // onclick <a> element
                                isSpecialCase = false, // true if interstitial 
should be shown despite not being a redirect
                                search = $target.prop( 'search' ), // query 
part of the link target URL
                                isImage = $target.hasClass( 'image' ), // is 
this a link to an image page

-- 
To view, visit https://gerrit.wikimedia.org/r/178420
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I51f186c5d92baa4be46f495d9a7ffd761048e344
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroBanner
Gerrit-Branch: master
Gerrit-Owner: Jhobs <[email protected]>
Gerrit-Reviewer: Yurik <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to