Jhernandez has submitted this change and it was merged.
Change subject: Pre-commit hook: Check jsdoc coverage of any touched files
......................................................................
Pre-commit hook: Check jsdoc coverage of any touched files
Change-Id: Iedee5cf753838f9e00982bda73360fe1841ca68a
---
M dev-scripts/pre-commit
1 file changed, 7 insertions(+), 8 deletions(-)
Approvals:
Jhernandez: Looks good to me, approved
diff --git a/dev-scripts/pre-commit b/dev-scripts/pre-commit
index 68c7b14..3ccfc0a 100755
--- a/dev-scripts/pre-commit
+++ b/dev-scripts/pre-commit
@@ -7,14 +7,13 @@
exit 1
fi
-# for file in `git diff --cached --name-only | grep -i ".js\$"`
-# do
-# echo "Beautifying $file"
-# if [ -f $file ]; then
-# node_modules/.bin/js-beautify -r "$file"
-# git add "$file"
-# fi
-# done
+for file in `git diff --cached --name-only | grep -i ".js\$"`
+do
+ echo 'Checking documentation coverage of files you have touched:'
+ if [ -f $file ]; then
+ node_modules/jscs/bin/jscs --config .jscs-jsdocrc "$file" ||
exit 1
+ fi
+done
make jshint || exit 1
make jscs || exit 1
--
To view, visit https://gerrit.wikimedia.org/r/177883
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedee5cf753838f9e00982bda73360fe1841ca68a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
