Ricordisamoa has uploaded a new change for review.
https://gerrit.wikimedia.org/r/178570
Change subject: Remove obsolete note from Title->canExist()
......................................................................
Remove obsolete note from Title->canExist()
A bit of history:
* when added by Aaron Schulz with commit
df1f744757b0ce695e6aa1e4a28f6c50fe6d8e20, the method made use of
a hardcoded `0`;
* Lisa Ridley noted that with
commit bc1023ac89f9214c6510d97869fb4f280084995f by adding
"uses hardcoded namespace index instead of constants";
* Max Semenik changed `0` to `NS_MAIN`, thus making the comment
obsolete, with commit a35fe1f5f2f8eda52a93eb974516c3b65918c819.
Change-Id: I0c2dad773219da80cc4db04ad6a8007a03207e5c
---
M includes/Title.php
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/70/178570/1
diff --git a/includes/Title.php b/includes/Title.php
index 638da08..e9fcf9a 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -1044,7 +1044,6 @@
* Is this in a namespace that allows actual pages?
*
* @return bool
- * @internal note -- uses hardcoded namespace index instead of constants
*/
public function canExist() {
return $this->mNamespace >= NS_MAIN;
--
To view, visit https://gerrit.wikimedia.org/r/178570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c2dad773219da80cc4db04ad6a8007a03207e5c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
