[MediaWiki-commits] [Gerrit] Update for I32608c7f in OOUI - change (mediawiki...VisualEditor)

[Code Review]

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/178625

Change subject: Update for I32608c7f in OOUI
......................................................................

Update for I32608c7f in OOUI

Bug: T76645
Change-Id: I64f5e2f6ccc0056bfa9eda5e65e87789b97b8ad5
---
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
M modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
M modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
3 files changed, 10 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/25/178625/1

diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
index 4993714..53f1368 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
@@ -420,7 +420,7 @@
        // Select the item without triggering the 'choose' event
        this.positionSelect.selectItem( item );
 
-       this.positionCheckbox.setValue( alignment !== 'none' );
+       this.positionCheckbox.setSelected( alignment !== 'none' );
        this.checkChanged();
 };
 
@@ -438,7 +438,7 @@
                !this.imageModel.isBorderable()
        );
 
-       this.borderCheckbox.setValue(
+       this.borderCheckbox.setSelected(
                this.imageModel.isBorderable() && this.imageModel.hasBorder()
        );
        this.checkChanged();
@@ -762,7 +762,7 @@
                ) :
                null
        );
-       this.positionCheckbox.setValue(
+       this.positionCheckbox.setSelected(
                this.imageModel.isAligned()
        );
 
@@ -770,7 +770,7 @@
        this.borderCheckbox.setDisabled(
                !this.imageModel.isBorderable()
        );
-       this.borderCheckbox.setValue(
+       this.borderCheckbox.setSelected(
                this.imageModel.isBorderable() && this.imageModel.hasBorder()
        );
 
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
index bf3bb43..79cb9a5 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
@@ -159,7 +159,7 @@
        this.displayTitleInput.setDisabled( !value );
        if ( !value ) {
                this.displayTitleInput.setValue( '' );
-               this.enableDisplayTitleInput.setValue( false );
+               this.enableDisplayTitleInput.setSelected( false );
        }
        this.displayTitleTouched = true;
 };
@@ -247,7 +247,7 @@
        newSectionEditField.selectItem( newSectionEditField.getItemFromData( 
newSectionEditLinkType ) );
        this.newSectionEditLinkOptionTouched = false;
 
-       this.enableDisplayTitleInput.setValue( !!displayTitleItem );
+       this.enableDisplayTitleInput.setSelected( !!displayTitleItem );
        this.displayTitleInput.setValue( displayTitle );
        this.displayTitleInput.setDisabled( !displayTitle );
        this.displayTitleTouched = false;
@@ -255,7 +255,7 @@
        // Simple checkbox items
        $.each( this.metaItemCheckboxes, function () {
                var currentValue = !!advancedSettingsPage.getMetaItem( 
this.metaName );
-               this.fieldLayout.getField().setValue( currentValue );
+               this.fieldLayout.getField().setSelected( currentValue );
        } );
 };
 
@@ -348,7 +348,7 @@
 
        $.each( this.metaItemCheckboxes, function () {
                var currentItem = advancedSettingsPage.getMetaItem( 
this.metaName ),
-                       newValue = this.fieldLayout.getField().getValue();
+                       newValue = this.fieldLayout.getField().isSelected();
 
                if ( currentItem && !newValue ) {
                        currentItem.remove();
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
index e1666b0..0129888 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
@@ -267,7 +267,7 @@
        // Simple checkbox items
        $.each( this.metaItemCheckboxes, function () {
                var currentValue = !!settingsPage.getMetaItem( this.metaName );
-               this.fieldLayout.getField().setValue( currentValue );
+               this.fieldLayout.getField().setSelected( currentValue );
        } );
 };
 
@@ -349,7 +349,7 @@
 
        $.each( this.metaItemCheckboxes, function () {
                var currentItem = settingsPage.getMetaItem( this.metaName ),
-                       newValue = this.fieldLayout.getField().getValue();
+                       newValue = this.fieldLayout.getField().isSelected();
 
                if ( currentItem && !newValue ) {
                        currentItem.remove();

-- 
To view, visit https://gerrit.wikimedia.org/r/178625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I64f5e2f6ccc0056bfa9eda5e65e87789b97b8ad5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits