Ricordisamoa has uploaded a new change for review. https://gerrit.wikimedia.org/r/178699
Change subject: BREAKING: make APISite.has_extension() case-sensitive ...................................................................... BREAKING: make APISite.has_extension() case-sensitive MediaWiki handles extension names case-sensitively, in fact some extensions' names only differ in capitalization: * https://www.mediawiki.org/wiki/Extension:BootStrap https://www.mediawiki.org/wiki/Extension:Bootstrap * https://www.mediawiki.org/wiki/Extension:WikiTeX https://www.mediawiki.org/wiki/Extension:WikiTex TestSiteExtensions.testExtensions() has been updated accordingly. Note: the now deprecated hasExtension() method has behaved case-insensitively since Merlijn van Deen's commit 149a90bfc0f53996ff6e6201e7ec0233cb2d78b1. Change-Id: I1d7aeaac0391693bb5a4b1a229205fabf3bba7e2 --- M pywikibot/site.py M tests/site_tests.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core refs/changes/99/178699/1 diff --git a/pywikibot/site.py b/pywikibot/site.py index e0f4b49..5a58f97 100644 --- a/pywikibot/site.py +++ b/pywikibot/site.py @@ -2113,7 +2113,7 @@ """ extensions = self.siteinfo['extensions'] for ext in extensions: - if ext['name'].lower() == name.lower(): + if ext['name'] == name: return True return False diff --git a/tests/site_tests.py b/tests/site_tests.py index 4b56794..a6ac605 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -1270,7 +1270,7 @@ self.assertTrue(mysite.has_extension('Disambiguator')) # test case-sensitivity - self.assertTrue(mysite.has_extension('disambiguator')) + self.assertFalse(mysite.has_extension('disambiguator')) self.assertFalse(mysite.has_extension('ThisExtensionDoesNotExist')) -- To view, visit https://gerrit.wikimedia.org/r/178699 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1d7aeaac0391693bb5a4b1a229205fabf3bba7e2 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Ricordisamoa <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
