Alex Monk has submitted this change and it was merged.
Change subject: Improve Echo Hooks
......................................................................
Improve Echo Hooks
BeforeFormatEchoNotification and BeforeCreateEchoEvent Hooks would be executed
multiple times because
* An action may fire multiple notification events
* The notification flyout and page have multiple notifications
we only want these hooks to run once to gather valid formatter and event
Change-Id: Ifff0ad34f3c44c31d88f982fd110ad3399ff5bd0
---
M controller/NotificationController.php
M model/Event.php
2 files changed, 14 insertions(+), 4 deletions(-)
Approvals:
Alex Monk: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/31347
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifff0ad34f3c44c31d88f982fd110ad3399ff5bd0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
