Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/178899
Change subject: Image caption should have parent document direction
......................................................................
Image caption should have parent document direction
Make sure all new caption surfaces are initialized with the language
and direction of the parent document, so the alignment is set up
correctly.
Bug: T71969
Change-Id: I6e5f003e18a9c5808d9a4b148eddf0d0f7e29e67
---
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/99/178899/1
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
index 4993714..5e2e658 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
@@ -789,7 +789,7 @@
*/
ve.ui.MWMediaDialog.prototype.resetCaption = function () {
var captionDocument,
- doc = this.getFragment().getSurface().getDocument();
+ doc = this.getFragment().getDocument();
if ( this.captionSurface ) {
// Reset the caption surface if it already exists
@@ -824,7 +824,12 @@
{ type: '/paragraph' },
{ type: 'internalList' },
{ type: '/internalList' }
- ] );
+ ],
+ // The ve.dm.Document constructor expects
+ // ( data, htmlDocument, parentDocument, internalList,
innerWhitespace, lang, dir )
+ // as parameters. We are only interested in setting up
language, hence the
+ // multiple 'null' values.
+ null, null, null, null, doc.getLang(), doc.getDir() );
}
this.store = doc.getStore();
--
To view, visit https://gerrit.wikimedia.org/r/178899
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e5f003e18a9c5808d9a4b148eddf0d0f7e29e67
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
