jenkins-bot has submitted this change and it was merged.
Change subject: Don't stop click propagation when clicked on hamburger
......................................................................
Don't stop click propagation when clicked on hamburger
It prevents other event handlers to do their jobs (e.g. drawer).
Change-Id: I96044437178291d477dad52ba185cdca0238a720
---
M javascripts/mainmenu.js
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/mainmenu.js b/javascripts/mainmenu.js
index 25399c2..1c01b04 100644
--- a/javascripts/mainmenu.js
+++ b/javascripts/mainmenu.js
@@ -35,12 +35,11 @@
openNavigationDrawer();
}
ev.preventDefault();
- ev.stopPropagation();
} );
// close navigation if content tapped
$( '#mw-mf-page-center' ).on( 'click', function ( ev ) {
- if ( isOpen() ) {
+ if ( ev.target.id !== 'mw-mf-main-menu-button' &&
isOpen() ) {
closeNavigationDrawers();
ev.preventDefault();
}
--
To view, visit https://gerrit.wikimedia.org/r/178675
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96044437178291d477dad52ba185cdca0238a720
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
