Faidon Liambotis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/179089

Change subject: Multiple cleanups
......................................................................

Multiple cleanups

- Use upstream version 20121211 to indicate that it's a git snapshot,
  rather than a released version from upstream.
- Do not close bug #1234 just to silence a Lintian warning
- Minor fixes to short/long Description
- Minor cleanups to the manpage
- Drop elfutils build-dependency as it's superfluous
- Remove /usr/share/dpkg/default.mk include from debian/rules
- Do not use quotes for setting DEB_CXXFLAGS_MAINT_APPEND &
  DEB_OBJCXXFLAGS_MAINT_APPEND as these are passed to GCC.
---
M debian/changelog
M debian/control
D debian/docs
M debian/quickstack.1
M debian/rules
5 files changed, 15 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/debs/quickstack 
refs/changes/89/179089/1

diff --git a/debian/changelog b/debian/changelog
index b981b5c..c2df069 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,5 @@
-quickstack (1.0-1) unstable; urgency=low
+quickstack (20121211-1) unstable; urgency=low
 
-  * Initial release (Closes: #1234)
+  * Initial release.
 
  -- Giuseppe Lavagetto <[email protected]>  Mon, 20 Oct 2014 11:14:28 
+0200
diff --git a/debian/control b/debian/control
index 4515659..f5cf5da 100644
--- a/debian/control
+++ b/debian/control
@@ -2,15 +2,14 @@
 Section: debug
 Priority: optional
 Maintainer: Giuseppe Lavagetto <[email protected]>
-Build-Depends: debhelper (>= 9), cmake, binutils-dev, libelf-dev, elfutils, 
libiberty-dev
+Build-Depends: debhelper (>= 9), cmake, binutils-dev, libelf-dev, libiberty-dev
 Standards-Version: 3.9.6
 Homepage: https://github.com/yoshinorim/quickstack/
-
 
 Package: quickstack
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
-Description: Tool to take call stack traces with minimal overheads.
+Description: call stack traces with minimal overheads
  There are a couple of tools to take stack traces such as gdb, pstack,
  but these tools have serious overheads. In many cases, target process
  stops for 0.2-N seconds. So it is dangerous to use such tools in
@@ -19,5 +18,4 @@
  you can frequently take stack traces in production environment. 
  .
  quickstack internally scans stack frames and guesses caller
- functions. For 64bit applications, it is highly recommended to build
- with -fno-omit-frame-pointer.
+ functions.
diff --git a/debian/docs b/debian/docs
deleted file mode 100644
index e845566..0000000
--- a/debian/docs
+++ /dev/null
@@ -1 +0,0 @@
-README
diff --git a/debian/quickstack.1 b/debian/quickstack.1
index 8237547..e284b24 100644
--- a/debian/quickstack.1
+++ b/debian/quickstack.1
@@ -1,37 +1,19 @@
-.\"                                      Hey, EMACS: -*- nroff -*-
 .\" (C) Copyright 2014 Giuseppe Lavagetto <[email protected]>,
 .\"
-.\" First parameter, NAME, should be all caps
-.\" Second parameter, SECTION, should be 1-8, maybe w/ subsection
-.\" other parameters are allowed: see man(7), man(1)
 .TH QUICKSTACK 1 "October 20, 2014"
-.\" Please adjust this date whenever revising the manpage.
-.\"
-.\" Some roff macros, for reference:
-.\" .nh        disable hyphenation
-.\" .hy        enable hyphenation
-.\" .ad l      left justify
-.\" .ad b      justify to both left and right margins
-.\" .nf        disable filling
-.\" .fi        enable filling
-.\" .br        insert line break
-.\" .sp <n>    insert n+1 empty lines
-.\" for manpage-specific macros, see man(7)
 .SH NAME
 quickstack \- tool to take call stack traces with minimal overheads.
 .SH SYNOPSIS
 .B quickstack
 .RI -p PID
 .SH DESCRIPTION
-This manual page documents briefly the
-.B There are a couple of tools to take stack traces such as gdb, pstack, but 
these tools
-have serious overheads. In many cases, target process stops for 0.2-N seconds.
-So it is dangerous to use such tools in production environment.
-quickstack makes it possible to take stack traces in less than 1 milliseconds. 
This is
-much smaller overhead so you can frequently take stack traces in production 
environment.
-.
+There are a couple of tools to take stack traces such as gdb, pstack, but these
+tools have serious overheads. In many cases, target process stops for 0.2-N
+seconds, so it is dangerous to use such tools in production environment.
+quickstack makes it possible to take stack traces in less than 1 milliseconds.
+This is much smaller overhead so you can frequently take stack traces in
+production environment.
 .SH "OPTIONS"
-There are not many options to specify
 .TP
 .B \-p PID,
 Specify the PID to take the stack trace of.
diff --git a/debian/rules b/debian/rules
index 77c87be..9f322be 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,8 +1,8 @@
 #!/usr/bin/make -f
-export DEB_CXXFLAGS_MAINT_APPEND="-fno-omit-frame-pointer"
-export DEB_OBJCXXFLAGS_MAINT_APPEND="-fno-omit-frame-pointer"
+
+export DEB_CXXFLAGS_MAINT_APPEND=-fno-omit-frame-pointer
+export DEB_OBJCXXFLAGS_MAINT_APPEND=-fno-omit-frame-pointer
 DPKG_EXPORT_BUILDFLAGS = 1
-include /usr/share/dpkg/default.mk
-# main packaging script based on dh7 syntax
+
 %:
        dh $@

-- 
To view, visit https://gerrit.wikimedia.org/r/179089
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I294bc3a6d344607e1061c60e46f58cc29a4dc47e
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/quickstack
Gerrit-Branch: master
Gerrit-Owner: Faidon Liambotis <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to