jenkins-bot has submitted this change and it was merged.
Change subject: [BREAKING CHANGE] Rename method cmpOffsetPaths to
compareOffsetPaths
......................................................................
[BREAKING CHANGE] Rename method cmpOffsetPaths to compareOffsetPaths
Change-Id: I701a2168b6eba1c0bc74fdc5cac37d67e26f8180
---
M src/ce/ve.ce.Surface.js
M src/ve.utils.js
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 6eff240..8bb587c 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -1221,7 +1221,7 @@
Array.prototype.indexOf.call( preUnicorn.parentNode.childNodes,
preUnicorn )
);
- if ( ve.cmpOffsetPaths( endCursorPos, preUnicornPos ) < 0 ) {
+ if ( ve.compareOffsetPaths( endCursorPos, preUnicornPos ) < 0 ) {
// before the pre-unicorn
fixup = -1;
} else {
diff --git a/src/ve.utils.js b/src/ve.utils.js
index 40330da..fc1c7ce 100644
--- a/src/ve.utils.js
+++ b/src/ve.utils.js
@@ -1154,7 +1154,7 @@
* @param {number[]} path2 Second offset path
* @return {number} negative, zero or positive number
*/
-ve.cmpOffsetPaths = function ( path1, path2 ) {
+ve.compareOffsetPaths = function ( path1, path2 ) {
var i, len;
for ( i = 0, len = Math.min( path1.length, path2.length ); i < len; i++
) {
if ( path1[ i ] !== path2[ i ] ) {
--
To view, visit https://gerrit.wikimedia.org/r/179393
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I701a2168b6eba1c0bc74fdc5cac37d67e26f8180
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
