Dzahn has submitted this change and it was merged.
Change subject: zuul: move parameters around for lint
......................................................................
zuul: move parameters around for lint
save 11x WARNING lines from puppet-lint/compiler:
optional parameter listed before required parameter
Change-Id: I15069cf0db0e6096ead6ed9881ef6ad7b4a5ea59
---
M modules/zuul/manifests/merger.pp
M modules/zuul/manifests/server.pp
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/zuul/manifests/merger.pp b/modules/zuul/manifests/merger.pp
index 9c3d84d..14dd490 100644
--- a/modules/zuul/manifests/merger.pp
+++ b/modules/zuul/manifests/merger.pp
@@ -17,13 +17,13 @@
#
class zuul::merger (
$gearman_server,
- $gerrit_baseurl = 'https://gerrit.wikimedia.org/r',
$gerrit_server,
$gerrit_user,
+ $url_pattern,
+ $gerrit_baseurl = 'https://gerrit.wikimedia.org/r',
$git_dir = '/var/lib/zuul/git',
$git_email = "zuul-merger@${::hostname}",
$git_name = 'Wikimedia Zuul Merger',
- $url_pattern,
$status_url = "https://${::fqdn}/zuul/status";,
$zuul_url = 'git://zuul.eqiad.wmnet',
) {
diff --git a/modules/zuul/manifests/server.pp b/modules/zuul/manifests/server.pp
index 397df2c..d243f30 100644
--- a/modules/zuul/manifests/server.pp
+++ b/modules/zuul/manifests/server.pp
@@ -20,16 +20,16 @@
# **statsd_host** IP/hostname of a statsd daemon to send metrics to. If unset
# (the default), nothing is ported.
class zuul::server (
- $statsd_host = '',
$gerrit_server,
$gerrit_user,
$gearman_server,
$gearman_server_start,
- $gerrit_baseurl = 'https://gerrit.wikimedia.org/r',
$jenkins_server,
$jenkins_user,
$jenkins_apikey,
$url_pattern,
+ $statsd_host = '',
+ $gerrit_baseurl = 'https://gerrit.wikimedia.org/r',
$status_url = "https://${::fqdn}/zuul/status";,
) {
--
To view, visit https://gerrit.wikimedia.org/r/179190
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15069cf0db0e6096ead6ed9881ef6ad7b4a5ea59
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Matanya <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
