Andrew Bogott has submitted this change and it was merged.
Change subject: openstack: firewall, enclose variables in {}
......................................................................
openstack: firewall, enclose variables in {}
fix 8 X WARNING: variable not enclosed in {}
Change-Id: I65ff9518730f1f6b68ea131ca2ee6f94e654e744
---
M modules/openstack/manifests/firewall.pp
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Andrew Bogott: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/openstack/manifests/firewall.pp
b/modules/openstack/manifests/firewall.pp
index b002ee4..e7bf4ac 100644
--- a/modules/openstack/manifests/firewall.pp
+++ b/modules/openstack/manifests/firewall.pp
@@ -30,28 +30,28 @@
# Redis replication for keystone
ferm::rule { 'redis_replication':
- rule => "saddr ($other_master) proto tcp dport (6379) ACCEPT;",
+ rule => "saddr (${other_master}) proto tcp dport (6379) ACCEPT;",
}
# internal services to Labs virt servers
ferm::rule { 'keystone':
- rule => "saddr ($other_master $labs_nodes) proto tcp dport (5000
35357) ACCEPT;",
+ rule => "saddr (${other_master} ${labs_nodes}) proto tcp dport (5000
35357) ACCEPT;",
}
ferm::rule { 'mysql_nova':
- rule => "saddr $labs_nodes proto tcp dport (3306) ACCEPT;",
+ rule => "saddr ${labs_nodes} proto tcp dport (3306) ACCEPT;",
}
ferm::rule { 'beam_nova':
- rule => "saddr $labs_nodes proto tcp dport (5672 56918) ACCEPT;",
+ rule => "saddr ${labs_nodes} proto tcp dport (5672 56918) ACCEPT;",
}
ferm::rule { 'glance_api_nova':
- rule => "saddr $labs_nodes proto tcp dport 9292 ACCEPT;",
+ rule => "saddr ${labs_nodes} proto tcp dport 9292 ACCEPT;",
}
# services provided to Labs instances
ferm::rule { 'puppetmaster':
- rule => "saddr $labs_private_net proto tcp dport 8140 ACCEPT;",
+ rule => "saddr ${labs_private_net} proto tcp dport 8140 ACCEPT;",
}
ferm::rule { 'salt':
- rule => "saddr $labs_private_net proto tcp dport (4505 4506) ACCEPT;",
+ rule => "saddr ${labs_private_net} proto tcp dport (4505 4506)
ACCEPT;",
}
}
--
To view, visit https://gerrit.wikimedia.org/r/179446
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65ff9518730f1f6b68ea131ca2ee6f94e654e744
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Andrew Bogott <abog...@wikimedia.org>
Gerrit-Reviewer: Matanya <mata...@foss.co.il>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
