Henning Snater has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179467
Change subject: Prevent focusing disabled toolbar buttons
......................................................................
Prevent focusing disabled toolbar buttons
Change-Id: Iada2b49530833c26493e22e41cdc465622a00e70
---
M lib/resources/jquery.wikibase/toolbar/jquery.wikibase.toolbarbutton.js
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/67/179467/1
diff --git
a/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.toolbarbutton.js
b/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.toolbarbutton.js
index 76e43e3..3666e9e 100644
--- a/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.toolbarbutton.js
+++ b/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.toolbarbutton.js
@@ -85,6 +85,12 @@
.removeClass( 'wikibase-toolbar-button-' +
this.options.cssClassSuffix );
}
this.element.addClass( 'wikibase-toolbar-button-' +
value );
+ } else if( key === 'disabled' ) {
+ if( value ) {
+ this.$link.attr( 'tabIndex', '-1' );
+ } else {
+ this.$link.removeAttr( 'tabIndex' );
+ }
}
return PARENT.prototype._setOption.apply( this, arguments );
},
--
To view, visit https://gerrit.wikimedia.org/r/179467
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iada2b49530833c26493e22e41cdc465622a00e70
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits