Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179476
Change subject: Kill the escape keydown event after handling a window close
......................................................................
Kill the escape keydown event after handling a window close
Bug: T78201
Change-Id: I959ade244f22abe38bca175a240166c3832e6fb2
---
M src/Dialog.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/76/179476/1
diff --git a/src/Dialog.js b/src/Dialog.js
index bdfc5e5..481b043 100644
--- a/src/Dialog.js
+++ b/src/Dialog.js
@@ -109,7 +109,8 @@
OO.ui.Dialog.prototype.onDocumentKeyDown = function ( e ) {
if ( e.which === OO.ui.Keys.ESCAPE ) {
this.close();
- return false;
+ e.preventDefault();
+ e.stopPropagation();
}
};
--
To view, visit https://gerrit.wikimedia.org/r/179476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I959ade244f22abe38bca175a240166c3832e6fb2
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
