BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/179542

Change subject: Do not require that a Monolog handler has a formatter
......................................................................

Do not require that a Monolog handler has a formatter

Not all handlers require a formatter.

Change-Id: Ifb31aa278d4e90b7fa3a2b7bf3b20173b8345afd
---
M includes/debug/logger/monolog/Spi.php
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/42/179542/1

diff --git a/includes/debug/logger/monolog/Spi.php 
b/includes/debug/logger/monolog/Spi.php
index c43e3d6..4ad5687 100644
--- a/includes/debug/logger/monolog/Spi.php
+++ b/includes/debug/logger/monolog/Spi.php
@@ -218,7 +218,11 @@
                if ( !isset( $this->singletons['handlers'][$name] ) ) {
                        $spec = $this->config['handlers'][$name];
                        $handler = ObjectFactory::getObjectFromSpec( $spec );
-                       $handler->setFormatter( $this->getFormatter( 
$spec['formatter'] ) );
+                       if ( isset( $spec['formatter'] ) ) {
+                               $handler->setFormatter(
+                                       $this->getFormatter( $spec['formatter'] 
)
+                               );
+                       }
                        $this->singletons['handlers'][$name] = $handler;
                }
                return $this->singletons['handlers'][$name];

-- 
To view, visit https://gerrit.wikimedia.org/r/179542
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb31aa278d4e90b7fa3a2b7bf3b20173b8345afd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to