[MediaWiki-commits] [Gerrit] Replace unneeded empty() calls - change (mediawiki...CommonsMetadata)

[Code Review]

Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/179860

Change subject: Replace unneeded empty() calls
......................................................................

Replace unneeded empty() calls

Bug: T78451
Change-Id: I08fbdceaa536125324e67bba6f66fa826a2b5547
---
M DataCollector.php
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CommonsMetadata 
refs/changes/60/179860/1

diff --git a/DataCollector.php b/DataCollector.php
index 51addf8..9de2cb5 100644
--- a/DataCollector.php
+++ b/DataCollector.php
@@ -341,7 +341,7 @@
         * @param array $informationTemplates an array of information templates 
, each is an array of metdata fields in fieldname => value form
         * @return array an array of metdata fields in fieldname => value form
         */
-       protected function selectInformationTemplate( $informationTemplates ) {
+       protected function selectInformationTemplate( array 
$informationTemplates ) {
                if ( !$informationTemplates ) {
                        return array();
                }
@@ -364,8 +364,8 @@
         * @param array $licenses an array of licenses, each is an array of 
metdata fields in fieldname => value form
         * @return array an array of metdata fields in fieldname => value form
         */
-       protected function selectLicense( $licenses ) {
-               if ( empty( $licenses ) ) {
+       protected function selectLicense( array $licenses ) {
+               if ( !$licenses ) {
                        return array();
                }
 
@@ -386,8 +386,8 @@
         * @param array $deletions
         * @return array a metadata key-value list; currently the only key is 
DeletionReason
         */
-       protected function selectDeletionReason( $deletions ) {
-               if ( empty( $deletions ) ) {
+       protected function selectDeletionReason( array $deletions ) {
+               if ( !$deletions ) {
                        return array();
                }
                return $deletions[0];

-- 
To view, visit https://gerrit.wikimedia.org/r/179860
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08fbdceaa536125324e67bba6f66fa826a2b5547
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CommonsMetadata
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits