Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179912
Change subject: Sprinkle some child selectors around in BookletLayout styles
......................................................................
Sprinkle some child selectors around in BookletLayout styles
PanelLayouts are commonly nested, and we don't want random
PanelLayouts getting weird width and padding treatments
just because they're inside another PanelLayout
that's inside a BookletLayout.
Bug: T78548
Change-Id: Ie0ddf21b5ab49f6d07f8e925c87b9b8aee1d8fa2
---
M src/styles/layouts/BookletLayout.less
M src/themes/apex/layouts.less
M src/themes/mediawiki/layouts.less
3 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/12/179912/1
diff --git a/src/styles/layouts/BookletLayout.less
b/src/styles/layouts/BookletLayout.less
index e311e6f..b31cb6d 100644
--- a/src/styles/layouts/BookletLayout.less
+++ b/src/styles/layouts/BookletLayout.less
@@ -2,11 +2,11 @@
.oo-ui-bookletLayout {
&-stackLayout {
- &.oo-ui-stackLayout-continuous .oo-ui-panelLayout-scrollable {
+ &.oo-ui-stackLayout-continuous > .oo-ui-panelLayout-scrollable {
overflow-y: hidden;
}
- .oo-ui-panelLayout {
+ > .oo-ui-panelLayout {
width: 100%;
.oo-ui-box-sizing(border-box);
@@ -22,7 +22,7 @@
}
&-outlinePanel {
- &-editable .oo-ui-outlineSelectWidget {
+ &-editable > .oo-ui-outlineSelectWidget {
position: absolute;
top: 0;
left: 0;
@@ -31,7 +31,7 @@
overflow-y: auto;
}
- .oo-ui-outlineControlsWidget {
+ > .oo-ui-outlineControlsWidget {
position: absolute;
bottom: 0;
left: 0;
diff --git a/src/themes/apex/layouts.less b/src/themes/apex/layouts.less
index be71716..2ae50fe 100644
--- a/src/themes/apex/layouts.less
+++ b/src/themes/apex/layouts.less
@@ -4,7 +4,7 @@
.theme-oo-ui-bookletLayout () {
&-stackLayout {
- .oo-ui-panelLayout {
+ > .oo-ui-panelLayout {
padding: 1.5em;
}
}
@@ -12,7 +12,7 @@
&-outlinePanel {
border-right: solid 1px #ddd;
- .oo-ui-outlineControlsWidget {
+ > .oo-ui-outlineControlsWidget {
box-shadow: 0 0 0.25em rgba(0,0,0,0.25);
}
}
diff --git a/src/themes/mediawiki/layouts.less
b/src/themes/mediawiki/layouts.less
index 9115f16..95f77fb 100644
--- a/src/themes/mediawiki/layouts.less
+++ b/src/themes/mediawiki/layouts.less
@@ -4,7 +4,7 @@
.theme-oo-ui-bookletLayout () {
&-stackLayout {
- .oo-ui-panelLayout {
+ > .oo-ui-panelLayout {
padding: 1.5em;
}
}
@@ -12,7 +12,7 @@
&-outlinePanel {
border-right: solid 1px #ddd;
- .oo-ui-outlineControlsWidget {
+ > .oo-ui-outlineControlsWidget {
box-shadow: 0 0 0.25em rgba(0,0,0,0.25);
}
}
--
To view, visit https://gerrit.wikimedia.org/r/179912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0ddf21b5ab49f6d07f8e925c87b9b8aee1d8fa2
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
