Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180085
Change subject: Revert "Prevent double clicks on gc cc forms"
......................................................................
Revert "Prevent double clicks on gc cc forms"
Issue is that we never reenable the radio buttons if there is a form error,
e.g. in email address.
This reverts commit 133bad751449ab6122b6ff7232fe23fee81d581f.
Change-Id: I4d19ff8960166be2e77556856bae0201a0d4739d
---
M globalcollect_gateway/forms/js/gc.cc.js
M globalcollect_gateway/forms/js/gc.js
2 files changed, 1 insertion(+), 7 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/85/180085/1
diff --git a/globalcollect_gateway/forms/js/gc.cc.js
b/globalcollect_gateway/forms/js/gc.cc.js
index 1005a4c..5f19108 100644
--- a/globalcollect_gateway/forms/js/gc.cc.js
+++ b/globalcollect_gateway/forms/js/gc.cc.js
@@ -55,14 +55,10 @@
} );
// Set the cards to progress to step 3
- $( '.cardradio' ).live( 'change', function (event) {
-
- $('.cardradio').prop('disabled', true);
-
+ $( '.cardradio' ).live( 'click', function () {
if ( validate_personal( document.payment ) && validateAmount()
) {
$( '#payment' ).animate( { height: '314px' }, 1000 );
displayCreditCardForm();
-
// hide the continue button so that people don't get
confused with two of them
$( '#paymentContinue' ).hide();
} else {
diff --git a/globalcollect_gateway/forms/js/gc.js
b/globalcollect_gateway/forms/js/gc.js
index f2e17d8..26f6237 100644
--- a/globalcollect_gateway/forms/js/gc.js
+++ b/globalcollect_gateway/forms/js/gc.js
@@ -82,11 +82,9 @@
mw.generatePaymentForm( data );
}
}
- $('.cardradio').prop('disabled', false);
},
error: function ( xhr ) {
alert( mw.msg( 'donate_interface-error-msg-general' ) );
- $('.cardradio').prop('disabled', false);
}
} );
};
--
To view, visit https://gerrit.wikimedia.org/r/180085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d19ff8960166be2e77556856bae0201a0d4739d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: deployment
Gerrit-Owner: Awight <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
