Ejegg has submitted this change and it was merged.
Change subject: satisfy jslint complaints about "define" and "require"
......................................................................
satisfy jslint complaints about "define" and "require"
Change-Id: Id018603cb367cbbb87488cc43bbeb61b0ba87020
---
M .jshintrc
M src/app/require.config.js
2 files changed, 10 insertions(+), 7 deletions(-)
Approvals:
Ejegg: Looks good to me, approved
diff --git a/.jshintrc b/.jshintrc
index 4586987..28fd7a2 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -38,11 +38,12 @@
// Legacy
"nomen": true,
- "predef": [
- "require",
- "module",
- "__dirname",
- "console",
- "process"
- ]
+ "globals": {
+ "console": false,
+ "define": false,
+ "__dirname": false,
+ "module": false,
+ "process": false,
+ "require": true
+ }
}
diff --git a/src/app/require.config.js b/src/app/require.config.js
index 28b931d..158f012 100644
--- a/src/app/require.config.js
+++ b/src/app/require.config.js
@@ -1,3 +1,5 @@
+/* jshint -W098 */
+
var require = {
baseUrl: '.',
paths: {
--
To view, visit https://gerrit.wikimedia.org/r/180094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id018603cb367cbbb87488cc43bbeb61b0ba87020
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Katie Horn <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
