Ejegg has submitted this change and it was merged.
Change subject: safe-ish lint fixups
......................................................................
safe-ish lint fixups
Change-Id: I132ad766ffac3e5e23537c824c7454dd33f6b8be
---
M src/app/require.config.js
M src/app/router.js
M src/components/app-content/app-content.js
M src/components/nav-bar/nav-bar.js
4 files changed, 6 insertions(+), 11 deletions(-)
Approvals:
Ejegg: Looks good to me, approved
diff --git a/src/app/require.config.js b/src/app/require.config.js
index 3908307..28b931d 100644
--- a/src/app/require.config.js
+++ b/src/app/require.config.js
@@ -1,5 +1,5 @@
var require = {
- baseUrl: ".",
+ baseUrl: '.',
paths: {
'bootstrap': 'bower_modules/bootstrap/dist/js/bootstrap',
'crossroads': 'bower_modules/crossroads/dist/crossroads.min',
diff --git a/src/app/router.js b/src/app/router.js
index f231f9e..7a57ffc 100644
--- a/src/app/router.js
+++ b/src/app/router.js
@@ -11,7 +11,8 @@
function Router( config ) {
var self = this;
- var currentRoute = self.currentRoute = ko.observable({});
+
+ self.currentRoute = ko.observable({});
crossroads.addRoute( ':page:/:action:', function( requestParams ) {
var routeParams = $.extend( config.defaultParams, requestParams );
diff --git a/src/components/app-content/app-content.js
b/src/components/app-content/app-content.js
index 42816ac..e3dc2b7 100644
--- a/src/components/app-content/app-content.js
+++ b/src/components/app-content/app-content.js
@@ -13,19 +13,13 @@
self.description = ko.observable();
self.graphs = ko.observableArray([]);
- var find = function(value){
- return function(e, i){
- return value === e;
- };
- };
-
self.loggedIn = ko.observable(false);
self.welcome = ko.observable('');
$.get('/user/info', function(userInfo) {
if (userInfo) {
- self.welcome(userInfo['name'].charAt(0).toUpperCase() +
userInfo['name'].slice(1));
+ self.welcome(userInfo.name.charAt(0).toUpperCase() +
userInfo.name.slice(1));
self.loggedIn(true);
- };
+ }
});
}
diff --git a/src/components/nav-bar/nav-bar.js
b/src/components/nav-bar/nav-bar.js
index d159db6..dcfa1c9 100644
--- a/src/components/nav-bar/nav-bar.js
+++ b/src/components/nav-bar/nav-bar.js
@@ -6,7 +6,7 @@
function NavBarViewModel( params ){
var self = this;
- self.loggedIn = params.loggedIn,
+ self.loggedIn = params.loggedIn;
self.welcome = params.welcome;
self.hideNav = function(){
--
To view, visit https://gerrit.wikimedia.org/r/180091
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I132ad766ffac3e5e23537c824c7454dd33f6b8be
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Katie Horn <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
