Ejegg has submitted this change and it was merged.
Change subject: require numeraljs before using
......................................................................
require numeraljs before using
Change-Id: I210202e37eedad6bdf84c75e702da3891eaecbe1
---
M src/components/widgets/amt-per-second-chart/amt-per-second-chart.js
M src/components/widgets/totals-earned-chart/totals-earned-chart.js
2 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Ejegg: Looks good to me, approved
diff --git
a/src/components/widgets/amt-per-second-chart/amt-per-second-chart.js
b/src/components/widgets/amt-per-second-chart/amt-per-second-chart.js
index 053fa73..3b36134 100644
--- a/src/components/widgets/amt-per-second-chart/amt-per-second-chart.js
+++ b/src/components/widgets/amt-per-second-chart/amt-per-second-chart.js
@@ -1,8 +1,9 @@
define( [
'knockout',
'text!components/widgets/amt-per-second-chart/amt-per-second-chart.html',
- 'c3'
-], function( ko, template, c3 ){
+ 'c3',
+ 'numeraljs'
+], function( ko, template, c3, numeral ){
function AmtPerSecondChartViewModel( params ){
diff --git a/src/components/widgets/totals-earned-chart/totals-earned-chart.js
b/src/components/widgets/totals-earned-chart/totals-earned-chart.js
index 9d29382..60d327e 100644
--- a/src/components/widgets/totals-earned-chart/totals-earned-chart.js
+++ b/src/components/widgets/totals-earned-chart/totals-earned-chart.js
@@ -1,8 +1,9 @@
define( [
'knockout',
'text!components/widgets/totals-earned-chart/totals-earned-chart.html',
- 'c3'
-], function( ko, template, c3 ){
+ 'c3',
+ 'numeraljs'
+], function( ko, template, c3, numeral ){
function TotalsEarnedChartViewModel( params ){
--
To view, visit https://gerrit.wikimedia.org/r/180101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I210202e37eedad6bdf84c75e702da3891eaecbe1
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
