BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/180108

Change subject: Guard dereference of iwPrefix['iw_trans'] and 
iwPrefix['iw_local']
......................................................................

Guard dereference of iwPrefix['iw_trans'] and iwPrefix['iw_local']

Ensure that array indices exist before access to avoid PHP interpreter
undefined index warnings.

Change-Id: I87021a358a85eb3adf7a222fbaee70623dfd8770
---
M Interwiki_body.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Interwiki 
refs/changes/08/180108/1

diff --git a/Interwiki_body.php b/Interwiki_body.php
index 5a41fe6..fa1bf2a 100644
--- a/Interwiki_body.php
+++ b/Interwiki_body.php
@@ -442,7 +442,7 @@
                        );
                        $attribs = array( 'class' => 'mw-interwikitable-local' 
);
                        // Green background for cells with "yes".
-                       if( $iwPrefix['iw_local'] ) {
+                       if( isset( $iwPrefix['iw_local'] ) && 
$iwPrefix['iw_local'] ) {
                                $attribs['class'] .= ' 
mw-interwikitable-local-yes';
                        }
                        // The messages interwiki_0 and interwiki_1 are used 
here.
@@ -452,7 +452,7 @@
                        $out .= Html::element( 'td', $attribs, $contents );
                        $attribs = array( 'class' => 'mw-interwikitable-trans' 
);
                        // Green background for cells with "yes".
-                       if( $iwPrefix['iw_trans'] ) {
+                       if( isset( $iwPrefix['iw_trans'] ) && 
$iwPrefix['iw_trans'] ) {
                                $attribs['class'] .= ' 
mw-interwikitable-trans-yes';
                        }
                        // The messages interwiki_0 and interwiki_1 are used 
here.

-- 
To view, visit https://gerrit.wikimedia.org/r/180108
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I87021a358a85eb3adf7a222fbaee70623dfd8770
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Interwiki
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to