jenkins-bot has submitted this change and it was merged.
Change subject: Wait for data before showing graphs
......................................................................
Wait for data before showing graphs
Should get rid of 'Source data missing a component' errors
Change-Id: I41b9d4338b117d3f4cf29243a8a00b8d91ad2cda
---
M src/components/widgets/amt-per-second-chart/amt-per-second-chart.js
M src/components/widgets/distance-to-goal-chart/distance-to-goal-chart.js
2 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Ssmith: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/src/components/widgets/amt-per-second-chart/amt-per-second-chart.js
b/src/components/widgets/amt-per-second-chart/amt-per-second-chart.js
index 053fa73..5eeaca6 100644
--- a/src/components/widgets/amt-per-second-chart/amt-per-second-chart.js
+++ b/src/components/widgets/amt-per-second-chart/amt-per-second-chart.js
@@ -12,6 +12,9 @@
self.title = ko.observable(params.title);
self.makeChart = function() {
+ if ( params.dayObj.length < 2 ) {
+ return;
+ }
var numPoints = ( params.lastDataPoint.day - 1 ) * 24 +
params.lastDataPoint.hour + 1,
xs = new Array( numPoints + 2 ), // label, data
to date, final point
index = 0,
diff --git
a/src/components/widgets/distance-to-goal-chart/distance-to-goal-chart.js
b/src/components/widgets/distance-to-goal-chart/distance-to-goal-chart.js
index eb4d94d..7cc8285 100644
--- a/src/components/widgets/distance-to-goal-chart/distance-to-goal-chart.js
+++ b/src/components/widgets/distance-to-goal-chart/distance-to-goal-chart.js
@@ -11,6 +11,9 @@
self.title = ko.observable(params.title);
self.makeCharts = function() {
+ if ( params.dailyDataArray.length < 2 ) {
+ return;
+ }
self.goal = ko.observable(params.goal);
self.updatedGoal = params.goal();
--
To view, visit https://gerrit.wikimedia.org/r/180111
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41b9d4338b117d3f4cf29243a8a00b8d91ad2cda
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
