Henning Snater has uploaded a new change for review. https://gerrit.wikimedia.org/r/180133
Change subject: badgselector: Suppress badges that refer to deleted items ...................................................................... badgselector: Suppress badges that refer to deleted items There is no point in allowing to select a badge that refers to a deleted item as saving would result in the back-end triggering an item-not-found error. ->76151 Change-Id: I0463ac65699803c81150b96d569f5775f1d685a0 --- M lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js M lib/resources/jquery.wikibase/resources.php 2 files changed, 8 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/33/180133/1 diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js b/lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js index 7431b97..b021f9e 100644 --- a/lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js +++ b/lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js @@ -2,7 +2,7 @@ * @licence GNU GPL v2+ * @author H. Snater < [email protected] > */ -( function( wb, $, mw ) { +( function( $, mw ) { 'use strict'; var PARENT = $.ui.TemplatedWidget; @@ -284,18 +284,15 @@ term = item && item.getFingerprint().getLabelFor( self.options.languageCode ), label = term && term.getText(); + if( !item ) { + return true; + } + var $item = $( '<a/>' ) .on( 'click.' + self.widgetName, function( event ) { event.preventDefault(); - } ); - - if( item ) { - $item.text( label || itemId ); - } else { - $item.append( - wb.utilities.ui.buildMissingEntityInfo( itemId, wb.datamodel.Item.TYPE ) - ); - } + } ) + .text( label || itemId ); $( '<li/>' ) .addClass( self.widgetBaseClass + '-menuitem-' + itemId ) @@ -543,4 +540,4 @@ } } ); -}( wikibase, jQuery, mediaWiki ) ); +}( jQuery, mediaWiki ) ); diff --git a/lib/resources/jquery.wikibase/resources.php b/lib/resources/jquery.wikibase/resources.php index f193584..696d46d 100644 --- a/lib/resources/jquery.wikibase/resources.php +++ b/lib/resources/jquery.wikibase/resources.php @@ -49,9 +49,7 @@ 'dependencies' => array( 'jquery.ui.menu', 'jquery.ui.TemplatedWidget', - 'wikibase.datamodel', 'wikibase.templates', - 'wikibase.utilities', ), ), -- To view, visit https://gerrit.wikimedia.org/r/180133 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0463ac65699803c81150b96d569f5775f1d685a0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
