Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180137
Change subject: Make some protected properties in EntityView private
......................................................................
Make some protected properties in EntityView private
Change-Id: I0af061a727eb95a8d9ed83a5653cbc126fad0253
---
M repo/includes/View/EntityView.php
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/37/180137/1
diff --git a/repo/includes/View/EntityView.php
b/repo/includes/View/EntityView.php
index b91c3cf..393900c 100644
--- a/repo/includes/View/EntityView.php
+++ b/repo/includes/View/EntityView.php
@@ -28,7 +28,7 @@
/**
* @var FingerprintView
*/
- protected $fingerprintView;
+ private $fingerprintView;
/**
* @var ClaimsView
@@ -48,7 +48,7 @@
/**
* @var TextInjector
*/
- protected $textInjector;
+ private $textInjector;
/**
* @param FingerprintView $fingerprintView
@@ -176,7 +176,7 @@
*
* @return string
*/
- protected function getHtmlForFingerprint( Entity $entity ) {
+ private function getHtmlForFingerprint( Entity $entity ) {
return $this->fingerprintView->getHtml(
$entity->getFingerprint(), $entity->getId(), $this->editable );
}
@@ -185,7 +185,7 @@
*
* @return string
*/
- protected function getHtmlForToc() {
+ private function getHtmlForToc() {
$tocSections = $this->getTocSections();
if ( count( $tocSections ) < 2 ) {
@@ -229,7 +229,7 @@
*
* @return string
*/
- protected function getHtmlForTermBox( EntityRevision $entityRevision ) {
+ private function getHtmlForTermBox( EntityRevision $entityRevision ) {
$entityId = $entityRevision->getEntity()->getId();
if ( $entityId !== null ) {
--
To view, visit https://gerrit.wikimedia.org/r/180137
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0af061a727eb95a8d9ed83a5653cbc126fad0253
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
