Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Fixed creating an empty entity
......................................................................
Fixed creating an empty entity
Change-Id: Ib26abf43cd8edf5412c9867d2fc30fded850d162
---
M README.md
M src/RepoApi.js
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Thiemo Mättig (WMDE): Verified; Looks good to me, approved
diff --git a/README.md b/README.md
index 8c60801..57088c8 100644
--- a/README.md
+++ b/README.md
@@ -7,6 +7,9 @@
#### Enhancements
* Updated code documentation to be able to generate documentation using JSDuck.
+### Bugfixes
+* An empty `Entity` may be created by omitting the `data` parameter on
`wikibase.api.RepoApi.createEntity()` again.
+
### 1.0.1 (2014-11-28)
* Bump the data-values/javascript dependency to 0.6.0 so that it matches
Wikibase.git's.
diff --git a/src/RepoApi.js b/src/RepoApi.js
index f90a70c..d688ca8 100644
--- a/src/RepoApi.js
+++ b/src/RepoApi.js
@@ -45,7 +45,7 @@
* @see wikibase.api.RepoApi._post
*
* @param {string} type The type of the `Entity` that should be created.
- * @param {Object} [data] The `Entity` data (may be omitted to create
an empty `Entity`).
+ * @param {Object} [data={}] The `Entity` data (may be omitted to
create an empty `Entity`).
* @return {Object} jQuery.Promise
* @return {Function} return.done
* @return {*} return.done.result
@@ -57,8 +57,8 @@
createEntity: function( type, data ) {
var params = {
action: 'wbeditentity',
- data: JSON.stringify( data ),
- 'new': type
+ 'new': type,
+ data: JSON.stringify( data || {} )
};
return this._post( params );
},
--
To view, visit https://gerrit.wikimedia.org/r/177502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib26abf43cd8edf5412c9867d2fc30fded850d162
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/WikibaseJavaScriptApi
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
