jenkins-bot has submitted this change and it was merged.

Change subject: Dont output base hrefs
......................................................................


Dont output base hrefs

We switched awhile ago to have redlinker rewrite all urls being output
as such this base href does nothing but confuse people as to how
things actually work.

Bug: T78090
Change-Id: Iebdbeb3efdbea278c26c6cb23cb89fcb6b3905ff
---
M includes/View.php
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  Matthias Mullie: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/View.php b/includes/View.php
index e5e62a6..908293d 100644
--- a/includes/View.php
+++ b/includes/View.php
@@ -69,13 +69,6 @@
                $workflow = $loader->getWorkflow();
 
                $title = $workflow->getArticleTitle();
-               // Temporary hack to make relative links work when the page is 
requested as /w/index.php?title=
-               // @todo this wont work when we eventually display posts from 
multiple source pages,
-               // @todo Patch core to either deprecate /w/index.php?title= and 
issue redirects, or
-               //   include the <base href="..."> directly from core
-               $out->prependHTML( Html::element( 'base', array(
-                       'href' => $title->getLinkURL()
-               ) ) );
 
                $request = $this->getRequest();
                $user = $this->getUser();

-- 
To view, visit https://gerrit.wikimedia.org/r/179512
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iebdbeb3efdbea278c26c6cb23cb89fcb6b3905ff
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to