jenkins-bot has submitted this change and it was merged.
Change subject: Clicking reply link should focus the text area
......................................................................
Clicking reply link should focus the text area
Fixes T69900
Bug: T69900
Change-Id: I8e015d09d7e6e509717038429b0d3620863064cc
---
M includes/UrlGenerator.php
M modules/engine/components/board/base/flow-board-interactive-events.js
2 files changed, 8 insertions(+), 1 deletion(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/UrlGenerator.php b/includes/UrlGenerator.php
index f5f1c08..f8adbca 100644
--- a/includes/UrlGenerator.php
+++ b/includes/UrlGenerator.php
@@ -431,6 +431,10 @@
UUID $postId,
$isTopLevelReply
) {
+ $hash = "#flow-post-{$postId->getAlphadecimal()}";
+ if ( $isTopLevelReply ) {
+ $hash .= "-form-content";
+ }
return new Anchor(
wfMessage( 'flow-reply-link' ),
$this->resolveTitle( $title, $workflowId ),
@@ -438,7 +442,7 @@
'action' => 'reply',
'topic_postId' => $postId->getAlphadecimal(),
),
- ( $isTopLevelReply ? '#flow-reply-' : '#flow-post-' ) .
$postId->getAlphadecimal()
+ $hash
);
}
diff --git
a/modules/engine/components/board/base/flow-board-interactive-events.js
b/modules/engine/components/board/base/flow-board-interactive-events.js
index 0659808..29c436b 100644
--- a/modules/engine/components/board/base/flow-board-interactive-events.js
+++ b/modules/engine/components/board/base/flow-board-interactive-events.js
@@ -297,6 +297,9 @@
$targetPost.children( '.flow-replies' ).append( $form );
$form.conditionalScrollIntoView();
+ // focus the input
+ $form.find('textarea').focus();
+
return $deferred.resolve().promise();
};
--
To view, visit https://gerrit.wikimedia.org/r/179352
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e015d09d7e6e509717038429b0d3620863064cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
