jenkins-bot has submitted this change and it was merged.

Change subject: Replace use of wfErrorLog() with MWLoggerLegacyLogger::emit()
......................................................................


Replace use of wfErrorLog() with MWLoggerLegacyLogger::emit()

When the logging service used by MediaWiki is not MWLoggerLegacySpi, the
behavior of the legacy wfErrorLog method is not guaranteed.
MWLoggerLegacyLogger::emit() is the suggested replacement for use cases
such as this one where the desired log destination is either a file or
a UDP endpoint.

Change-Id: I585daf95e6187b91cddac6130f8f690f33aacbb6
---
M ClickTracking.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ClickTracking.hooks.php b/ClickTracking.hooks.php
index b55a5f1..44eba25 100644
--- a/ClickTracking.hooks.php
+++ b/ClickTracking.hooks.php
@@ -231,7 +231,7 @@
                                (int)$contribs_in_timespan3,
                                str_replace( "\t", ' ', $additional ),
                        ) );
-                       wfErrorLog( $msg, $wgClickTrackingLog );
+                       MWLoggerLegacyLogger::emit( $msg, $wgClickTrackingLog );
 
                        // No need to mess with $retval here, doing
                        // $retval == $retval && true is useless

-- 
To view, visit https://gerrit.wikimedia.org/r/180074
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I585daf95e6187b91cddac6130f8f690f33aacbb6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ClickTracking
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to