Subramanya Sastry has uploaded a new change for review. Change subject: ExpansionCache.get should return tokens after freezing them. ......................................................................
ExpansionCache.get should return tokens after freezing them. * Util.deepFreeze does not return the frozen object. Because of this, ExpansionCache.get was always returning undefined. This broke parsing and RTing of several pages -- haven't investigated why this should be so since returning undefined should be equivalent to a cache miss? Bug found via git bisect on en:Ta_Mok and other pages. * This fix eliminates parsing and RT-bug on en:Ta_Mok, en:Barack_Obama and other pages where incorrect <pre> is introduced in parse output which also messes up RT-ing This parse/RT fix works when applied to SHA 96b4d64. * This bug fix will not fix RTing of the above pages on master because SHA 42d265a gets in the way. That commit retains newlines and whitespace after "|" in template params which then introduces the <pre> problem in all scenarios. This interaction is a bit mysterious and worth further investigation. A separate commit will deal with this. Change-Id: I81ffa31c7c282d83df008fcdca857c26e5f97933 --- M js/lib/mediawiki.TokenTransformManager.js 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/23/31723/1 -- To view, visit https://gerrit.wikimedia.org/r/31723 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I81ffa31c7c282d83df008fcdca857c26e5f97933 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
