Jhernandez has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/180452

Change subject: Fix borders in main menu hover
......................................................................

Fix borders in main menu hover

Because both border left and top were in the `li` border top was only going
till half the big border left, thus not going completely to the left.

I've moved the border left that appears on hover to the `a` so that the li
border can expand fully.

Bug: T1161
Change-Id: I91f672403899dbb7991487e7454b7834031fed33
---
M less/mainmenu.less
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/52/180452/1

diff --git a/less/mainmenu.less b/less/mainmenu.less
index 592ab35..35860eb 100644
--- a/less/mainmenu.less
+++ b/less/mainmenu.less
@@ -138,8 +138,10 @@
 
                &:hover {
                        background-color: @colorGray5;
-                       border-left: solid @menuBorder #3366BB;
                        margin-left: -@menuBorder;
+                       a {
+                               border-left: solid @menuBorder #3366BB;
+                       }
                }
 
                a {
@@ -149,11 +151,11 @@
 
                        // FIXME: Remove when cache cleared
                        &.icon {
-                               padding: 13px 10px 11px 34px;
+                               background-position-x: 9px;
+                               padding: 13px 10px 11px 43px;
                                line-height: 22px;
                        }
 
-                       margin-left: 9px;
                        &:hover {
                                text-decoration: none;
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/180452
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I91f672403899dbb7991487e7454b7834031fed33
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to