Phuedx has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180454
Change subject: Hide the Nearby main menu button correctly
......................................................................
Hide the Nearby main menu button correctly
Actually remove the Nearby main menu button when the browser doesn't
support geolocation.
Bug: T78780
Change-Id: I172cfcf8f52ae20530930a330c0175e5d488f83a
---
M includes/skins/SkinMinerva.php
M javascripts/mainmenu.js
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/54/180454/1
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 88479f9..693ce8b 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -443,7 +443,7 @@
array(
'text' => wfMessage(
'mobile-frontend-main-menu-nearby' )->escaped(),
'href' =>
SpecialPage::getTitleFor( 'Nearby' )->getLocalURL(),
- 'class' => MobileUI::iconClass(
'nearby', 'before' ),
+ 'class' => MobileUI::iconClass(
'nearby', 'before', 'nearby' ),
),
),
'class' => 'jsonly',
diff --git a/javascripts/mainmenu.js b/javascripts/mainmenu.js
index fbd9d23..5fd594a 100644
--- a/javascripts/mainmenu.js
+++ b/javascripts/mainmenu.js
@@ -60,7 +60,7 @@
$( '<div class="transparent-shield cloaked-element">'
).appendTo( '#mw-mf-page-center' );
if ( !browser.supportsGeoLocation() ) {
- $( '#mw-mf-page-left li.icon-nearby' ).remove();
+ $( '#mw-mf-page-left .nearby' ).parent().remove();
}
}
--
To view, visit https://gerrit.wikimedia.org/r/180454
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I172cfcf8f52ae20530930a330c0175e5d488f83a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
